Refactoring

tkc · tkc · commit 8a6e35bbb167 · 2020-10-11T11:07:37.000+09:00
diff --git a/src/usecase/services/report_service.go b/src/usecase/services/report_service.go
@@ -29,15 +29,13 @@ func NewReportService(
 func (s reportService) Show(validator model.Validator) {
 	res, _ := s.generalLogRepository.GetQueries()
 	reportPresenter := presenter.NewReportPresenter()
-
-	var analyzers []model.Analyzer
+	var analyzers = make([]model.Analyzer, len(res))
 	for _, query := range res {
 		astNode, err := s.analyzerService.Parse(query)
 		if err != nil {
 			panic(err)
 		}
 		analyzers = append(analyzers, *s.analyzerService.Extract(&astNode, query))
 	}
-
 	reportPresenter.Show(s.validatesService.Validates(analyzers, validator))
 }

Original file line number	Diff line number	Diff line change
`@@ -29,15 +29,13 @@ func NewReportService(`
`29`	`29`	`func (s reportService) Show(validator model.Validator) {`
`30`	`30`	`res, _ := s.generalLogRepository.GetQueries()`
`31`	`31`	`reportPresenter := presenter.NewReportPresenter()`
`32`		`-`
`33`		`- var analyzers []model.Analyzer`
	`32`	`+ var analyzers = make([]model.Analyzer, len(res))`
`34`	`33`	`for _, query := range res {`
`35`	`34`	`astNode, err := s.analyzerService.Parse(query)`
`36`	`35`	`if err != nil {`
`37`	`36`	`panic(err)`
`38`	`37`	`}`
`39`	`38`	`analyzers = append(analyzers, *s.analyzerService.Extract(&astNode, query))`
`40`	`39`	`}`
`41`		`-`
`42`	`40`	`reportPresenter.Show(s.validatesService.Validates(analyzers, validator))`
`43`	`41`	`}`