Test issues with file extensions

Author: tkruse

cpplint_unittest.py

@@ -257,18 +257,19 @@ def TestIncludeWhatYouUse(self, code, expected_message):
                       self.PerformIncludeWhatYouUse(code))
 
   def TestBlankLinesCheck(self, lines, start_errors, end_errors):
-    error_collector = ErrorCollector(self.assert_)
-    cpplint.ProcessFileData('foo.cc', 'cc', lines, error_collector)
-    self.assertEquals(
-        start_errors,
-        error_collector.Results().count(
-            'Redundant blank line at the start of a code block '
-            'should be deleted.  [whitespace/blank_line] [2]'))
-    self.assertEquals(
-        end_errors,
-        error_collector.Results().count(
-            'Redundant blank line at the end of a code block '
-            'should be deleted.  [whitespace/blank_line] [3]'))
+    for extension in ['c', 'cc', 'cpp', 'cxx', 'c++', 'cu']:
+        error_collector = ErrorCollector(self.assert_)
+        cpplint.ProcessFileData('foo.' + extension, extension, lines, error_collector)
+        self.assertEquals(
+            start_errors,
+            error_collector.Results().count(
+                'Redundant blank line at the start of a code block '
+                'should be deleted.  [whitespace/blank_line] [2]'))
+        self.assertEquals(
+            end_errors,
+            error_collector.Results().count(
+                'Redundant blank line at the end of a code block '
+                'should be deleted.  [whitespace/blank_line] [3]'))
 
 
 class CpplintTest(CpplintTestBase):
@@ -777,11 +778,13 @@ def testTypedefForPointerToFunction(self):
 
   def testIncludeWhatYouUseNoImplementationFiles(self):
     code = 'std::vector<int> foo;'
-    self.assertEquals('Add #include <vector> for vector<>'
-                      '  [build/include_what_you_use] [4]',
-                      self.PerformIncludeWhatYouUse(code, 'foo.h'))
-    self.assertEquals('',
-                      self.PerformIncludeWhatYouUse(code, 'foo.cc'))
+    for extension in ['h', 'hpp', 'hxx', 'h++', 'cuh']:
+        self.assertEquals('Add #include <vector> for vector<>'
+                          '  [build/include_what_you_use] [4]',
+                      self.PerformIncludeWhatYouUse(code, 'foo.' + extension))
+    for extension in ['c', 'cc', 'cpp', 'cxx', 'c++', 'cu']:
+        self.assertEquals('',
+                          self.PerformIncludeWhatYouUse(code, 'foo.' + extension))
 
   def testIncludeWhatYouUse(self):
     self.TestIncludeWhatYouUse(
@@ -966,7 +969,12 @@ def testFilesBelongToSameModule(self):
     f = cpplint.FilesBelongToSameModule
     self.assertEquals((True, ''), f('a.cc', 'a.h'))
     self.assertEquals((True, ''), f('base/google.cc', 'base/google.h'))
-    self.assertEquals((True, ''), f('base/google_test.cc', 'base/google.h'))
+    self.assertEquals((True, ''), f('base/google_test.c', 'base/google.h'))
+    self.assertEquals((True, ''), f('base/google_test.cc', 'base/google.hpp'))
+    self.assertEquals((True, ''), f('base/google_test.cxx', 'base/google.hxx'))
+    self.assertEquals((True, ''), f('base/google_test.cpp', 'base/google.hpp'))
+    self.assertEquals((True, ''), f('base/google_test.c++', 'base/google.h++'))
+    self.assertEquals((True, ''), f('base/google_test.cu', 'base/google.cuh'))
     self.assertEquals((True, ''),
                       f('base/google_unittest.cc', 'base/google.h'))
     self.assertEquals((True, ''),
@@ -1123,16 +1131,17 @@ def testMultilineStrings(self):
         'Use C++11 raw strings or concatenation instead.'
         '  [readability/multiline_string] [5]')
 
-    file_path = 'mydir/foo.cc'
+    for extension in ['c', 'cc', 'cpp', 'cxx', 'c++', 'cu']:
+        file_path = 'mydir/foo.' + extension
 
-    error_collector = ErrorCollector(self.assert_)
-    cpplint.ProcessFileData(file_path, 'cc',
-                            ['const char* str = "This is a\\',
-                             ' multiline string.";'],
-                            error_collector)
-    self.assertEquals(
-        2,  # One per line.
-        error_collector.ResultList().count(multiline_string_error_message))
+        error_collector = ErrorCollector(self.assert_)
+        cpplint.ProcessFileData(file_path, extension,
+                                ['const char* str = "This is a\\',
+                                 ' multiline string.";'],
+                                error_collector)
+        self.assertEquals(
+            2,  # One per line.
+            error_collector.ResultList().count(multiline_string_error_message))
 
   # Test non-explicit single-argument constructors
   def testExplicitSingleArgumentConstructors(self):
@@ -3947,18 +3956,20 @@ def testDuplicateHeader(self):
         error_collector.ResultList())
 
   def testUnnamedNamespacesInHeaders(self):
-    self.TestLanguageRulesCheck(
-        'foo.h', 'namespace {',
-        'Do not use unnamed namespaces in header files.  See'
-        ' http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
-        ' for more information.  [build/namespaces] [4]')
-    # namespace registration macros are OK.
-    self.TestLanguageRulesCheck('foo.h', 'namespace {  \\', '')
-    # named namespaces are OK.
-    self.TestLanguageRulesCheck('foo.h', 'namespace foo {', '')
-    self.TestLanguageRulesCheck('foo.h', 'namespace foonamespace {', '')
-    self.TestLanguageRulesCheck('foo.cc', 'namespace {', '')
-    self.TestLanguageRulesCheck('foo.cc', 'namespace foo {', '')
+    for extension in ['h', 'hpp', 'hxx', 'h++', 'cuh']:
+        self.TestLanguageRulesCheck(
+            'foo.' + extension, 'namespace {',
+            'Do not use unnamed namespaces in header files.  See'
+            ' http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
+            ' for more information.  [build/namespaces] [4]')
+        # namespace registration macros are OK.
+        self.TestLanguageRulesCheck('foo.' + extension, 'namespace {  \\', '')
+        # named namespaces are OK.
+        self.TestLanguageRulesCheck('foo.' + extension, 'namespace foo {', '')
+        self.TestLanguageRulesCheck('foo.' + extension, 'namespace foonamespace {', '')
+    for extension in ['c', 'cc', 'cpp', 'cxx', 'c++', 'cu']:
+        self.TestLanguageRulesCheck('foo.' + extension, 'namespace {', '')
+        self.TestLanguageRulesCheck('foo.' + extension, 'namespace foo {', '')
 
   def testBuildClass(self):
     # Test that the linter can parse to the end of class definitions,
@@ -4675,15 +4686,30 @@ def testClassifyInclude(self):
 
   def testTryDropCommonSuffixes(self):
     self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo-inl.h'))
+    self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo-inl.hxx'))
+    self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo-inl.h++'))
+    self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo-inl.hpp'))
     self.assertEqual('foo/bar/foo',
                      cpplint._DropCommonSuffixes('foo/bar/foo_inl.h'))
     self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo.cc'))
+    self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo.cxx'))
+    self.assertEqual('foo/foo', cpplint._DropCommonSuffixes('foo/foo.c'))
     self.assertEqual('foo/foo_unusualinternal',
                      cpplint._DropCommonSuffixes('foo/foo_unusualinternal.h'))
+    self.assertEqual('foo/foo_unusualinternal',
+                     cpplint._DropCommonSuffixes('foo/foo_unusualinternal.hpp'))
     self.assertEqual('',
                      cpplint._DropCommonSuffixes('_test.cc'))
+    self.assertEqual('',
+                     cpplint._DropCommonSuffixes('_test.c'))
+    self.assertEqual('',
+                     cpplint._DropCommonSuffixes('_test.c++'))
+    self.assertEqual('test',
+                     cpplint._DropCommonSuffixes('test.c'))
     self.assertEqual('test',
                      cpplint._DropCommonSuffixes('test.cc'))
+    self.assertEqual('test',
+                     cpplint._DropCommonSuffixes('test.c++'))
 
   def testRegression(self):
     def Format(includes):