New ruff rules, reduce line length to 99 (#392)

* ISC

* SIM

* line length

* furb

Author: tlambert03

backend/config/api_router.py

@@ -4,10 +4,7 @@
 import proteins.api.urls
 from fpbase.users.api.views import UserViewSet
 
-if settings.DEBUG:
-    router = DefaultRouter()
-else:
-    router = SimpleRouter()
+router = DefaultRouter() if settings.DEBUG else SimpleRouter()
 
 router.register("users", UserViewSet)
 

backend/config/settings/base.py

@@ -26,7 +26,8 @@
 READ_DOT_ENV_FILE = env.bool("DJANGO_READ_DOT_ENV_FILE", default=False)
 
 if READ_DOT_ENV_FILE:
-    # Operating System Environment variables have precedence over variables defined in the .env file,
+    # Operating System Environment variables have precedence over variables defined in the
+    # .env file,
     # that is to say variables from the .env files will only be used if not defined
     # as environment variables.
     env_file = str(ROOT_DIR / ".env")
@@ -322,7 +323,8 @@
     "DEFAULT_SCHEMA_CLASS": "drf_spectacular.openapi.AutoSchema",
 }
 
-# By Default swagger ui is available only to admin user(s). You can change permission classes to change that
+# By Default swagger ui is available only to admin user(s). You can change permission
+# classes to change that
 # See more configuration options at https://drf-spectacular.readthedocs.io/en/latest/settings.html#settings
 SPECTACULAR_SETTINGS = {
     "TITLE": "fpbase API",
@@ -464,17 +466,18 @@ def add_sentry_context(logger, method_name, event_dict):
     using the ID to find the full exception context in Sentry.
     """
     # Check if sentry_event_id was explicitly passed in extra dict
-    if "sentry_event_id" not in event_dict:
-        # Try to get it from Sentry SDK's last_event_id()
-        # This works if Django/Sentry integration auto-captured an exception
-        if event_dict.get("exc_info") or "exception" in event_dict:
-            try:
-                import sentry_sdk
-
-                if event_id := sentry_sdk.last_event_id():
-                    event_dict["sentry_event_id"] = event_id
-            except (ImportError, AttributeError, Exception):
-                pass  # Sentry not available
+    # Try to get it from Sentry SDK's last_event_id()
+    # This works if Django/Sentry integration auto-captured an exception
+    if "sentry_event_id" not in event_dict and (
+        event_dict.get("exc_info") or "exception" in event_dict
+    ):
+        try:
+            import sentry_sdk
+
+            if event_id := sentry_sdk.last_event_id():
+                event_dict["sentry_event_id"] = event_id
+        except (ImportError, AttributeError, Exception):
+            pass  # Sentry not available
 
     return event_dict
 

backend/config/settings/local.py

@@ -29,7 +29,9 @@
 EMAIL_PORT = 1025
 
 EMAIL_HOST = "localhost"
-EMAIL_BACKEND = env("DJANGO_EMAIL_BACKEND", default="django.core.mail.backends.console.EmailBackend")
+EMAIL_BACKEND = env(
+    "DJANGO_EMAIL_BACKEND", default="django.core.mail.backends.console.EmailBackend"
+)
 
 if env("MAILGUN_API_KEY", default=False) and env("MAILGUN_DOMAIN", default=False):
     INSTALLED_APPS += [

backend/config/settings/production.py

@@ -205,7 +205,9 @@ def WHITENOISE_IMMUTABLE_FILE_TEST(path, url):
     send_default_pii=True,
     release=HEROKU_SLUG_COMMIT,
     traces_sample_rate=env.float("SENTRY_TRACES_SAMPLE_RATE", default=0.1),  # 10% of all requests
-    profiles_sample_rate=env.float("SENTRY_PROFILES_SAMPLE_RATE", default=0.05),  # 5% of traced requests
+    profiles_sample_rate=env.float(
+        "SENTRY_PROFILES_SAMPLE_RATE", default=0.05
+    ),  # 5% of traced requests
 )
 
 # Scout APM Configuration
@@ -322,7 +324,7 @@ def WHITENOISE_IMMUTABLE_FILE_TEST(path, url):
 
 # Enable API and GraphQL rate limiting in production
 REST_FRAMEWORK["DEFAULT_THROTTLE_CLASSES"] = [
-    "fpbase.views.SameOriginExemptAnonThrottle",  # Custom throttle that exempts same-origin requests
+    "fpbase.views.SameOriginExemptAnonThrottle",  # Custom throttle that exempts same-origin
     "rest_framework.throttling.UserRateThrottle",
 ]
 # NOTE: Rate limiting settings are used by both REST API and GraphQL

backend/config/urls.py

@@ -71,7 +71,6 @@
         TemplateView.as_view(template_name="pages/bleaching.html"),
         name="bleaching",
     ),
-    # path('mutations/', TemplateView.as_view(template_name='pages/mutations.html'), name='mutations'),
     path(
         "robots.txt",
         TemplateView.as_view(template_name="robots.txt", content_type="text/plain"),

backend/conftest.py

@@ -61,8 +61,12 @@ def mock_get_organism_info(organism_id: str | int):
         }
 
     # Use unittest.mock.patch for session-scoped mocking
-    patcher1 = unittest.mock.patch("proteins.extrest.entrez.doi_lookup", side_effect=mock_doi_lookup)
-    patcher2 = unittest.mock.patch("proteins.extrest.entrez.get_organism_info", side_effect=mock_get_organism_info)
+    patcher1 = unittest.mock.patch(
+        "proteins.extrest.entrez.doi_lookup", side_effect=mock_doi_lookup
+    )
+    patcher2 = unittest.mock.patch(
+        "proteins.extrest.entrez.get_organism_info", side_effect=mock_get_organism_info
+    )
 
     patcher1.start()
     patcher2.start()

backend/favit/managers.py

@@ -112,7 +112,9 @@ def get_favorite(self, user, obj, model=None):
             return None
 
         try:
-            return self.get_query_set().get(user=user, target_content_type=content_type, target_object_id=obj.id)
+            return self.get_query_set().get(
+                user=user, target_content_type=content_type, target_object_id=obj.id
+            )
         except self.model.DoesNotExist:
             return None
 

backend/favit/models.py

@@ -22,7 +22,9 @@ class Favorite(models.Model):
         on_delete=models.CASCADE,
     )
     target_content_type_id: int
-    target_content_type: models.ForeignKey[ContentType] = models.ForeignKey(ContentType, on_delete=models.CASCADE)
+    target_content_type: models.ForeignKey[ContentType] = models.ForeignKey(
+        ContentType, on_delete=models.CASCADE
+    )
     target_object_id = models.PositiveIntegerField()
     target = GenericForeignKey("target_content_type", "target_object_id")
     timestamp = models.DateTimeField(auto_now_add=True, db_index=True)

backend/fpbase/__init__.py

@@ -3,7 +3,9 @@
 from fpbase.celery import app as celery_app
 
 __version__ = "0.1.0"
-__version_info__ = tuple([int(num) if num.isdigit() else num for num in __version__.replace("-", ".", 1).split(".")])
+__version_info__ = tuple(
+    [int(num) if num.isdigit() else num for num in __version__.replace("-", ".", 1).split(".")]
+)
 
 
 __all__ = ("celery_app",)

backend/fpbase/decorators.py

@@ -44,7 +44,9 @@ def login_required_message_and_redirect(
     message=default_message,
 ):
     if function:
-        return login_required_message(login_required(function, redirect_field_name, login_url), message)
+        return login_required_message(
+            login_required(function, redirect_field_name, login_url), message
+        )
 
     return lambda deferred_function: login_required_message_and_redirect(
         deferred_function, redirect_field_name, login_url, message