Skip to content

Conversation

Sadeeed
Copy link
Collaborator

@Sadeeed Sadeeed commented Oct 3, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

#18348

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Oct 3, 2025
@Managor Managor mentioned this pull request Oct 3, 2025
18 tasks
@Sadeeed
Copy link
Collaborator Author

Sadeeed commented Oct 4, 2025

@Managor I accidentally committed your requested changes with the default commit message, should i create a new pr to fix the message as changing it now will require a force push

@Managor
Copy link
Member

Managor commented Oct 4, 2025

No. It doesn't matter. We squash and merge anyways

@Managor
Copy link
Member

Managor commented Oct 4, 2025

I noticed you only contribute during hacktoberfest, but you provide pretty quality documentation. Would you be interested joining as a contributor?

@Sadeeed
Copy link
Collaborator Author

Sadeeed commented Oct 4, 2025

Sure I'd love that, it's just that Hacktoberfest became part of my yearly routine and I keep returning to it.

@Managor
Copy link
Member

Managor commented Oct 6, 2025

Sorry for the bother, but we just changed the style guide to have a different order for options. #18491

It's for a good reason though. I didn't realize the issue when I originally wrote that part of the guide.

@Sadeeed
Copy link
Collaborator Author

Sadeeed commented Oct 7, 2025

Updated the argument ordering according to the new style, hopefully this fixes most of the issues

@Managor Managor merged commit 7439ae8 into tldr-pages:main Oct 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants