chore(api): fixed swagger doc for attributes

Author: tleon

src/ApiPlatform/Resources/Attribute/Attribute.php

@@ -93,6 +93,7 @@ class Attribute
     public int $attributeGroupId;
 
     #[LocalizedValue]
+    #[Assert\NotBlank(groups: ['Create'])]
     #[DefaultLanguage(groups: ['Create'], fieldName: 'names')]
     #[DefaultLanguage(groups: ['Update'], fieldName: 'names', allowNull: true)]
     #[Assert\All(constraints: [
@@ -108,16 +109,14 @@ class Attribute
     #[Assert\NotBlank(allowNull: true)]
     public array $shopIds;
 
-    public int $position;
-
     public const QUERY_MAPPING = [
         '[localizedNames]' => '[names]',
         '[name]' => '[names]',
         '[associatedShopIds]' => '[shopIds]',
     ];
 
     public const CREATE_COMMAND_MAPPING = [
-        '[names]' => '[localizedValue]',
+        '[names]' => '[localizedNames]',
         '[shopIds]' => '[associatedShopIds]',
     ];
 

tests/Integration/ApiPlatform/ContactEndpointTest.php

@@ -131,7 +131,13 @@ public function testPartialUpdateContact(int $contactId): int
         $updatedContact = $this->partialUpdateItem('/contacts/' . $contactId, $patchData, ['contact_write']);
         $this->assertSame($patchData['names'], $updatedContact['names']);
         $this->assertSame($patchData['email'], $updatedContact['email']);
-        $this->assertSame((bool) $patchData['messagesSavingEnabled'], (bool) $updatedContact['messagesSavingEnabled']);
+
+        // We check that when we GET the item it is updated as expected
+        $contact = $this->getItem('/contacts/' . $contactId, ['contact_read']);
+        $this->assertSame($patchData['names'], $contact['names']);
+        $this->assertSame($patchData['email'], $contact['email']);
+        $this->assertArrayHasKey('messagesSavingEnabled', $contact);
+        $this->assertSame((bool) $patchData['messagesSavingEnabled'], (bool) $contact['messagesSavingEnabled']);
 
         return $contactId;
     }