Skip to content

Commit 5595eda

Browse files
authored
Merge pull request #24 from RUB-NDS/bbFalsePositveFailedScan
Fixed false positive on errornous scans in bleichenbacher
2 parents f0b6741 + 4a2a774 commit 5595eda

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/main/java/de/rub/nds/tlsscanner/probe/BleichenbacherProbe.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,16 @@ public ProbeResult executeTest() {
7373
LOGGER.debug("Testing: " + bbWorkflowType);
7474
BleichenbacherAttacker attacker = new BleichenbacherAttacker(bleichenbacherConfig, scannerConfig.createConfig(), getParallelExecutor());
7575
EqualityError errorType = attacker.getEqualityError();
76-
vulnerable |= (errorType != EqualityError.NONE);
77-
resultList.add(new BleichenbacherTestResult(errorType != EqualityError.NONE, bleichenbacherConfig.getType(), bbWorkflowType, attacker.getFingerprintPairList(), errorType));
76+
Boolean tempVulnerable;
77+
if (errorType == null) {
78+
tempVulnerable = null;
79+
} else if (errorType != EqualityError.NONE) {
80+
tempVulnerable = true;
81+
vulnerable |= tempVulnerable;
82+
} else {
83+
tempVulnerable = false;
84+
}
85+
resultList.add(new BleichenbacherTestResult(tempVulnerable, bleichenbacherConfig.getType(), bbWorkflowType, attacker.getFingerprintPairList(), errorType));
7886
}
7987
return new BleichenbacherResult(vulnerable, resultList);
8088
}

0 commit comments

Comments
 (0)