Skip to content

Commit 86662f9

Browse files
author
TLS-Attacker Fix Bot
committed
Fix MS_SHOULD_BE_FINAL SpotBugs issue (#169)
Made static fields final to fix SpotBugs MS_SHOULD_BE_FINAL warnings: - DtlsHelloVerifyRequestProbe.COOKIE_LENGTH_ERROR_VALUE - QuicRetryPacketProbe.RETRY_TOKEN_LENGTH_ERROR_VALUE - DefaultRatingLoader.LOGGER - DefaultRatingLoader.INFLUENCERS_RESOURCE_LOCATION
1 parent edc1ecf commit 86662f9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

TLS-Server-Scanner/src/main/java/de/rub/nds/tlsscanner/serverscanner/probe/DtlsHelloVerifyRequestProbe.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545

4646
public class DtlsHelloVerifyRequestProbe extends TlsServerProbe {
4747

48-
public static Integer COOKIE_LENGTH_ERROR_VALUE = -1;
48+
public static final Integer COOKIE_LENGTH_ERROR_VALUE = -1;
4949

5050
private TestResult supportsCookieExchange = TestResults.COULD_NOT_TEST;
5151
private TestResult hasHvrRetransmissions = TestResults.COULD_NOT_TEST;

TLS-Server-Scanner/src/main/java/de/rub/nds/tlsscanner/serverscanner/probe/quic/QuicRetryPacketProbe.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
public class QuicRetryPacketProbe extends QuicServerProbe {
4141

42-
public static Integer RETRY_TOKEN_LENGTH_ERROR_VALUE = -1;
42+
public static final Integer RETRY_TOKEN_LENGTH_ERROR_VALUE = -1;
4343

4444
private TestResult hasRetryTokenRetransmissions;
4545
private TestResult checksRetryToken;

TLS-Server-Scanner/src/main/java/de/rub/nds/tlsscanner/serverscanner/report/rating/DefaultRatingLoader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@
2727
*/
2828
public class DefaultRatingLoader {
2929

30-
private static Logger LOGGER = LogManager.getLogger();
30+
private static final Logger LOGGER = LogManager.getLogger();
3131

3232
/**
3333
* The resource location for the rating influencers XML file. This file contains the
3434
* configuration for how different properties influence the overall rating of a TLS server.
3535
*/
36-
public static String INFLUENCERS_RESOURCE_LOCATION = "rating/influencers.xml";
36+
public static final String INFLUENCERS_RESOURCE_LOCATION = "rating/influencers.xml";
3737

3838
/**
3939
* The default resource template path for recommendation files. Language-specific versions can

0 commit comments

Comments
 (0)