Skip to content

Commit 8ba1001

Browse files
committed
Merge remote-tracking branch 'public/master'
# Conflicts: # README.md # src/main/java/de/rub/nds/tlsscanner/report/SiteReport.java # src/main/java/de/rub/nds/tlsscanner/report/SiteReportPrinter.java
2 parents a3c0f31 + 2016a3b commit 8ba1001

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/main/java/de/rub/nds/tlsscanner/Main.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import de.rub.nds.tlsattacker.core.config.delegate.GeneralDelegate;
1414
import de.rub.nds.tlsattacker.core.exceptions.ConfigurationException;
1515
import de.rub.nds.tlsscanner.config.ScannerConfig;
16+
import de.rub.nds.tlsscanner.constants.AnsiColors;
1617
import de.rub.nds.tlsscanner.constants.AnsiEscapeSequence;
1718
import de.rub.nds.tlsscanner.report.SiteReport;
1819
import java.io.IOException;
@@ -47,11 +48,11 @@ public static void main(String[] args) throws IOException {
4748
LOGGER.info("Performing Scan, this may take some time...");
4849
SiteReport report = scanner.scan();
4950
LOGGER.info("Scanned in:" + ((System.currentTimeMillis() - time) / 1000) + "s\n");
50-
if (!config.getGeneralDelegate().isDebug()) {
51+
if (!config.getGeneralDelegate().isDebug() && !config.isNoProgressbar()) {
5152
// ANSI escape sequences to erase the progressbar
5253
ConsoleLogger.CONSOLE.info(AnsiEscapeSequence.ANSI_ONE_LINE_UP + AnsiEscapeSequence.ANSI_ERASE_LINE);
5354
}
54-
ConsoleLogger.CONSOLE.info("Scanned in: " + ((System.currentTimeMillis() - time) / 1000) + "s\n" + report.getFullReport(config.getReportDetail()));
55+
ConsoleLogger.CONSOLE.info(AnsiColors.ANSI_RESET + "Scanned in: " + ((System.currentTimeMillis() - time) / 1000) + "s\n" + report.getFullReport(config.getReportDetail()));
5556
} catch (ConfigurationException E) {
5657
LOGGER.error("Encountered a ConfigurationException aborting.", E);
5758
}

src/main/java/de/rub/nds/tlsscanner/probe/certificate/CertificateReportGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ private static void setCommonNames(CertificateReport report,
9696
if (x500name != null) {
9797
RDN[] rdNs = x500name.getRDNs(BCStyle.CN);
9898
for (int i = 0; i < rdNs.length; i++) {
99-
commonNames.append(IETFUtils.valueToString(rdNs[i]));
99+
commonNames.append(IETFUtils.valueToString(rdNs[i].getFirst().getValue()));
100100
if (i < rdNs.length - 1) {
101101
commonNames.append(" ,");
102102
}

src/main/java/de/rub/nds/tlsscanner/report/SiteReportPrinter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,15 +1055,15 @@ private StringBuilder prettyAppendHeading(StringBuilder builder, String value) {
10551055
}
10561056

10571057
private StringBuilder prettyAppendUnderlined(StringBuilder builder, String name, String value) {
1058-
return builder.append(addIndentations(name)).append(": ").append(AnsiColors.ANSI_UNDERLINE + value + AnsiColors.ANSI_RESET).append("\n");
1058+
return builder.append(addIndentations(name)).append(": ").append((report.isNoColor() == false ? AnsiColors.ANSI_UNDERLINE + value + AnsiColors.ANSI_RESET : value)).append("\n");
10591059
}
10601060

10611061
private StringBuilder prettyAppendUnderlined(StringBuilder builder, String name, boolean value) {
1062-
return builder.append(addIndentations(name)).append(": ").append(AnsiColors.ANSI_UNDERLINE + value + AnsiColors.ANSI_RESET).append("\n");
1062+
return builder.append(addIndentations(name)).append(": ").append((report.isNoColor() == false ? AnsiColors.ANSI_UNDERLINE + value + AnsiColors.ANSI_RESET : value)).append("\n");
10631063
}
10641064

10651065
private StringBuilder prettyAppendUnderlined(StringBuilder builder, String name, long value) {
1066-
return builder.append(addIndentations(name)).append(": ").append(AnsiColors.ANSI_UNDERLINE + value + AnsiColors.ANSI_RESET).append("\n");
1066+
return builder.append(addIndentations(name)).append(": ").append((report.isNoColor() == false ? AnsiColors.ANSI_UNDERLINE + value + AnsiColors.ANSI_RESET : value)).append("\n");
10671067
}
10681068

10691069
private StringBuilder prettyAppendSubheading(StringBuilder builder, String name) {

0 commit comments

Comments
 (0)