Merge pull request #61 from RUB-NDS/certificatePathValidationResultCausesBug

Certificate path validation bugfix

Author: ic0ns

pom.xml

@@ -3,7 +3,7 @@
     <modelVersion>4.0.0</modelVersion>
     <artifactId>TLS-Scanner</artifactId>
     <groupId>de.rub.nds.tlsscanner</groupId>
-    <version>2.11</version>
+    <version>2.11.1</version>
     <packaging>jar</packaging>
     <dependencies>
         <dependency>
@@ -40,13 +40,13 @@
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
-            <version>2.9.8</version>
+            <version>2.10.0</version>
             <type>jar</type>
         </dependency>
         <dependency>
             <groupId>com.fasterxml.jackson.dataformat</groupId>
             <artifactId>jackson-dataformat-yaml</artifactId>
-            <version>2.9.8</version>
+            <version>2.10.0</version>
         </dependency>
         <dependency>
             <groupId>org.apache.commons</groupId>

src/main/java/de/rub/nds/tlsscanner/probe/certificate/CertificateChain.java

@@ -202,8 +202,10 @@ public CertificateChain(Certificate certificate, String uri) {
             generallyTrusted = certPathValidationResult.isValid();
             if (!generallyTrusted) {
                 CertPathValidationException[] causes = certPathValidationResult.getCauses();
-                for (CertPathValidationException exception : causes) {
-                    exception.printStackTrace();
+                if (causes != null) {
+                    for (CertPathValidationException exception : causes) {
+                        exception.printStackTrace();
+                    }
                 }
             }
         } else {

src/main/java/de/rub/nds/tlsscanner/trust/TrustAnchorManager.java

@@ -30,6 +30,7 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Set;
+import java.util.TreeSet;
 import javax.security.auth.x500.X500Principal;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
@@ -135,7 +136,7 @@ private Set<TrustAnchor> getFullTrustAnchorSet() {
         } catch (IOException | NoSuchAlgorithmException | CertificateException | KeyStoreException | InvalidAlgorithmParameterException ex) {
             LOGGER.error("Could not build TrustAnchorSet", ex);
         }
-        return null;
+        return new HashSet<>();
     }
 
     public Set<TrustAnchor> getTrustAnchorSet() {