Skip to content

Commit cff0a4d

Browse files
committed
Fixed quick mode in padding oracle and bleichenbacher
1 parent 28aa5d5 commit cff0a4d

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/main/java/de/rub/nds/tlsscanner/probe/BleichenbacherProbe.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,12 @@ public ProbeResult executeTest() {
5555
}
5656
LOGGER.info("Fetched the following server public key: " + publicKey);
5757
List<Pkcs1Vector> pkcs1Vectors;
58-
if (scannerConfig.getScanDetail() == ScannerDetail.NORMAL) {
59-
pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FAST,
58+
if (scannerConfig.getScanDetail().isGreaterEqualTo(ScannerDetail.DETAILED)) {
59+
pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FULL,
6060
bleichenbacherConfig.createConfig().getDefaultHighestClientProtocolVersion());
61+
6162
} else {
62-
pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FULL,
63+
pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FAST,
6364
bleichenbacherConfig.createConfig().getDefaultHighestClientProtocolVersion());
6465
}
6566
List<BleichenbacherTestResult> resultList = new LinkedList<>();

src/main/java/de/rub/nds/tlsscanner/probe/PaddingOracleProbe.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,12 @@ public ProbeResult executeTest() {
128128
}
129129
}
130130
}
131-
if (vulnerable && recordGeneratorType != PaddingRecordGeneratorType.SHORT) {
131+
if (vulnerable && (ScannerDetail.QUICK != scannerConfig.getScanDetail())) {
132132
testResultList.clear();
133133
//Perform full scan
134-
recordGeneratorType = PaddingRecordGeneratorType.SHORT;
134+
if (recordGeneratorType == PaddingRecordGeneratorType.VERY_SHORT) {
135+
recordGeneratorType = PaddingRecordGeneratorType.SHORT;
136+
}
135137
for (ProtocolVersion version : versionList) {
136138

137139
VersionSuiteListPair suitePairList = null;

0 commit comments

Comments
 (0)