Skip to content

Commit fa311d7

Browse files
committed
Changed log level of some logging statements
1 parent 300e599 commit fa311d7

File tree

5 files changed

+9
-14
lines changed

5 files changed

+9
-14
lines changed

src/main/java/de/rub/nds/tlsscanner/MultiThreadedScanJobExecutor.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ private SiteReport scan(ScannerConfig config, ScanJob scanJob, ProgressBar pb) {
8787
try {
8888
resultList.add(probeResult.get());
8989
} catch (InterruptedException | ExecutionException ex) {
90-
LOGGER.warn("Encoutered Exception while retrieving probeResult");
91-
ex.printStackTrace();
92-
LOGGER.warn(ex);
90+
LOGGER.error("Encoutered Exception while retrieving probeResult", ex);
9391
}
9492
}
9593

@@ -131,9 +129,7 @@ private SiteReport scan(ScannerConfig config, ScanJob scanJob, ProgressBar pb) {
131129
try {
132130
resultList.add(probeResult.get());
133131
} catch (InterruptedException | ExecutionException ex) {
134-
LOGGER.warn("Encoutered Exception while retrieving probeResult");
135-
ex.printStackTrace();
136-
LOGGER.warn(ex);
132+
LOGGER.error("Encoutered Exception while retrieving probeResult", ex);
137133
}
138134
}
139135
// mergeData phase 2

src/main/java/de/rub/nds/tlsscanner/SingleThreadedScanJobExecutor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ private SiteReport scan(ScannerConfig config, ScanJob scanJob, ProgressBar pb) {
8080
pb.step();
8181
}
8282
} catch (Exception E) {
83-
LOGGER.warn("Could not execute Probe", E);
83+
LOGGER.error("Could not execute Probe", E);
8484
}
8585
probeTypes.add(probe.getType());
8686
}
@@ -94,7 +94,7 @@ private SiteReport scan(ScannerConfig config, ScanJob scanJob, ProgressBar pb) {
9494
try {
9595
result.merge(report);
9696
} catch (Exception E) {
97-
LOGGER.warn("Could not merge SiteReport", E);
97+
LOGGER.error("Could not merge SiteReport", E);
9898
}
9999
}
100100
//Finished phase one starting phase 2
@@ -117,7 +117,7 @@ private SiteReport scan(ScannerConfig config, ScanJob scanJob, ProgressBar pb) {
117117
pb.step();
118118
}
119119
} catch (Exception E) {
120-
LOGGER.warn("Could not execute Probe", E);
120+
LOGGER.error("Could not execute Probe", E);
121121
}
122122
} else if (!config.isImplementation()) {
123123
ProbeResult result = probe.getNotExecutedResult();
@@ -135,7 +135,7 @@ private SiteReport scan(ScannerConfig config, ScanJob scanJob, ProgressBar pb) {
135135
try {
136136
result.merge(report);
137137
} catch (Exception E) {
138-
LOGGER.warn("Could not merge SiteReport", E);
138+
LOGGER.error("Could not merge SiteReport", E);
139139
}
140140
}
141141
//phase 3 - collect statistics

src/main/java/de/rub/nds/tlsscanner/probe/PaddingOracleProbe.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public ProbeResult executeTest() {
118118
try {
119119
lastResult = attacker.isVulnerable();
120120
} catch (Exception E) {
121-
LOGGER.warn("PaddingOracle Unstable - you should probably test this manually", E);
121+
LOGGER.error("Encountered an exception while testing for PaddingOracles", E);
122122
lastResult = null;
123123
hasError = true;
124124
}

src/main/java/de/rub/nds/tlsscanner/probe/TokenbindingProbe.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ private Set<TokenBindingVersion> getSupportedVersions() {
122122
}
123123

124124
} catch (WorkflowExecutionException ex) {
125-
LOGGER.warn("Could not execute Workflow to determine supported Tokenbinding Versions");
126-
LOGGER.debug(ex);
125+
LOGGER.error("Could not execute Workflow to determine supported Tokenbinding Versions", ex);
127126
}
128127
}
129128
return supportedVersions;

src/main/java/de/rub/nds/tlsscanner/probe/certificate/CertificateReportGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ private static void setPubkey(CertificateReportImplementation report, org.bouncy
123123
report.setPublicKey(x509Cert.getPublicKey());
124124
}
125125
} catch (CertificateParsingException ex) {
126-
LOGGER.warn("Could not parse PublicKey from certificate", ex);
126+
LOGGER.error("Could not parse PublicKey from certificate", ex);
127127
}
128128
}
129129

0 commit comments

Comments
 (0)