Skip to content

Commit d86aba9

Browse files
committed
make codeclimate work for external PRs too
1 parent ba2b058 commit d86aba9

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,10 @@ jobs:
318318
- name: Publish coverage to Codeclimate
319319
if: ${{ contains(matrix.opt-deps, 'codeclimate') }}
320320
env:
321-
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
321+
# yes, one could argue that making even a "write-only" token public is bad practice
322+
# but it's practice that the codeclimate explicitly supports:
323+
# https://docs.codeclimate.com/docs/finding-your-test-coverage-token#should-i-keep-my-test-reporter-id-secret
324+
CC_TEST_REPORTER_ID: 192c24c0112eddbedbb0570c7e0111858061be407451b285e27b5a43f70b99d8
322325
run: |
323326
coverage xml
324327
./cc-test-reporter after-build

0 commit comments

Comments
 (0)