Issue #1, #14 - now using a loop to increase the buffer size for QueryDosDevice API if it is not enough to hold all DOS device names. The loop is limited to 10 cycles.

Author: tmcdos

RamRemove.pas

@@ -98,7 +98,7 @@ function AutoEjectVolume(AVolumeHandle: THandle): boolean;
     begin
       dw:=GetLastError;
       if dw = ERROR_FILE_NOT_FOUND then DebugLog('Arsenal Driver not installed',EVENTLOG_ERROR_TYPE)
-      else DebugLog(SysErrorMessage(dw),EVENTLOG_ERROR_TYPE);
+      else DebugLog('Can not open the SCSI adapter when detaching RAM-disk = ' + SysErrorMessage(dw),EVENTLOG_ERROR_TYPE);
       raise ERamDiskError.Create(RamNotInstalled);
     end;
     deviceNumber.LongNumber:=IMSCSI_ALL_DEVICES;
@@ -112,7 +112,7 @@ function AutoEjectVolume(AVolumeHandle: THandle): boolean;
       end
       else
       begin
-        DebugLog(SysErrorMessage(dw),EVENTLOG_ERROR_TYPE);
+        DebugLog('Can not remove the SCSI adapter = ' + SysErrorMessage(dw),EVENTLOG_ERROR_TYPE);
         Exit;
       end;
     end;

RamVolume.pas

@@ -26,26 +26,38 @@ function GetVolumePathNamesForVolumeName(lpszVolumeName, lpszVolumePathNames: LP
   dw: DWORD;
   dev_path: WideString;
   config:TScsiDeviceConfig;
-  i, len: Integer;
+  i, len, multiple: Integer;
   devices: TStringList;
   address: TScsiAddress;
   device_number: TStorageDeviceNumber;
   disk_size: Int64;
 Begin
-  SetLength(dosDevs, MAX_DOS_NAMES);
   disk_number:= -1;
   Result:=INVALID_HANDLE_VALUE;
-  len:=QueryDosDevice(NIL, PAnsiChar(dosdevs), Length(dosdevs));
-  // ImScsiDebugMessage(L"Error opening SCSI port %1!i!: %2!ws!", PortNumber & 0xFF, (LPCWSTR)errmsg);
-  if len=0 then Exit;
-
+  multiple:=1;
+  Repeat
+    SetLength(dosDevs, MAX_DOS_NAMES * multiple);
+    len:=QueryDosDevice(NIL, PAnsiChar(dosdevs), Length(dosdevs));
+    // ImScsiDebugMessage(L"Error opening SCSI port %1!i!: %2!ws!", PortNumber & 0xFF, (LPCWSTR)errmsg);
+    if len=0 then Inc(multiple);
+    if multiple > 10 then
+    begin
+      DebugLog(Format('QueryDosDevice can not fit DOS device names inside %d bytes',[Length(dosdevs)]),EVENTLOG_ERROR_TYPE);
+      Exit;
+    end;
+  Until len <> 0;
   adapter := ImScsiOpenScsiAdapterByScsiPortNumber(PortNumber);
-  if adapter = INVALID_HANDLE_VALUE then Exit;
+  if adapter = INVALID_HANDLE_VALUE then
+  Begin
+    DebugLog('Could not open SCSI adapter inside ImScsiOpenDiskByDeviceNumber',EVENTLOG_ERROR_TYPE);
+    Exit;
+  end;
 
   config.DeviceNumber := DeviceNumber;
   If not ImScsiQueryDevice(adapter, @config, SizeOf(TScsiDeviceConfig)) Then
   begin
     CloseHandle(adapter);
+    DebugLog('Could not get SCSI device config inside ImScsiOpenDiskByDeviceNumber',EVENTLOG_ERROR_TYPE);
     Exit;
   end;
   CloseHandle(adapter);
@@ -95,7 +107,11 @@ function GetVolumePathNamesForVolumeName(lpszVolumeName, lpszVolumePathNames: LP
         ERROR_INVALID_PARAMETER,
         ERROR_INVALID_FUNCTION,
         ERROR_NOT_SUPPORTED,
-        ERROR_IO_DEVICE: break;
+        ERROR_IO_DEVICE:
+        Begin
+          DebugLog(Format('Could not get the SCSI address of device %s',[devices[i]]),EVENTLOG_ERROR_TYPE);
+          break;
+        end;
       end;
       CloseHandle(disk);
     end;

RamdiskUI.dof

@@ -115,7 +115,7 @@ AutoIncBuild=0
 MajorVer=1
 MinorVer=1
 Release=1
-Build=10
+Build=11
 Debug=0
 PreRelease=0
 Special=0
@@ -126,7 +126,7 @@ CodePage=1251
 [Version Info Keys]
 CompanyName=
 FileDescription=
-FileVersion=1.1.1.10
+FileVersion=1.1.1.11
 InternalName=
 LegalCopyright=
 LegalTrademarks=

RamdiskUI.res

@@ -131,8 +131,8 @@ procedure TArsenalRamDisk.ServiceStart(Sender: TService; var Started: Boolean);
   try
     if CreateRamDisk(config,False) Then Started:=True;
   except
-    On E:ERamDiskError do DebugLog(decodeException(E.ArsenalCode));
-    On E:Exception do DebugLog(E.Message);
+    On E:ERamDiskError do DebugLog('Service could not create RAM-disk, error = ' + decodeException(E.ArsenalCode));
+    On E:Exception do DebugLog('Exception in service start = ' + E.Message);
   End;
 end;
 
@@ -145,8 +145,8 @@ procedure TArsenalRamDisk.ServiceStop(Sender: TService; var Stopped: Boolean);
     try
       If DetachRamDisk(config) then Stopped:=True;
     except
-      On E:ERamDiskError do DebugLog(decodeException(E.ArsenalCode));
-      On E:Exception Do DebugLog(E.Message);
+      On E:ERamDiskError do DebugLog('Service could not destroy RAM-disk, error = ' + decodeException(E.ArsenalCode));
+      On E:Exception Do DebugLog('Exception in service stop = ' + E.Message);
     end;
   End
   Else Stopped:=True;