Add -Xline-directives flag to shermes compilation

tmikov · tmikov · commit f23d4e3ed636 · 2025-11-13T21:03:37.000-08:00
Enable line directives in shermes output to improve source mapping
in stack traces and error messages. This makes debugging JavaScript
code compiled with shermes significantly easier.

Applied to all build configurations (not just Debug) as the overhead
is negligible and the benefit applies to all scenarios.
diff --git a/cmake/hermes.cmake b/cmake/hermes.cmake
@@ -74,6 +74,7 @@ function(hermes_compile_native)
         $<$<CONFIG:Debug>:-g3>
         --exported-unit=${ARG_UNIT_NAME}
         -Xes6-block-scoping
+        -Xline-directives
     )
     if(ARG_FLAGS)
         list(APPEND COMPILER_FLAGS ${ARG_FLAGS})

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ function(hermes_compile_native)`
`74`	`74`	`$<$<CONFIG:Debug>:-g3>`
`75`	`75`	`--exported-unit=${ARG_UNIT_NAME}`
`76`	`76`	`-Xes6-block-scoping`
	`77`	`+ -Xline-directives`
`77`	`78`	`)`
`78`	`79`	`if(ARG_FLAGS)`
`79`	`80`	`list(APPEND COMPILER_FLAGS ${ARG_FLAGS})`