refactor: do not try to reuse previously added timer with same values and simply push new timers as they are defined

Author: tmlmt

src/classes/recipe.ts

@@ -18,7 +18,6 @@ import {
   ingredientAliasRegex,
 } from "../regex";
 import {
-  findOrPush,
   flushPendingItems,
   flushPendingNote,
   findAndUpsertIngredient,
@@ -265,15 +264,7 @@ export class Recipe {
             duration,
             unit,
           };
-          const idxInList = findOrPush(
-            this.timers,
-            (t) =>
-              t.name === timerObj.name &&
-              t.duration === timerObj.duration &&
-              t.unit === timerObj.unit,
-            () => timerObj,
-          );
-          items.push({ type: "timer", value: idxInList });
+          items.push({ type: "timer", value: this.timers.push(timerObj) - 1 });
         }
 
         cursor = idx + match[0].length;

src/parser_helpers.ts

@@ -17,25 +17,6 @@ import {
   Quantity,
 } from "./units";
 
-/**
- * Finds an item in a list or adds it if not present, then returns its index.
- * @param list - The list to search in.
- * @param finder - A predicate to find the item.
- * @param creator - A function to create the item if not found.
- * @returns The index of the item in the list.
- */
-export function findOrPush<T>(
-  list: T[],
-  finder: (elem: T) => boolean,
-  creator: () => T,
-): number {
-  let index = list.findIndex(finder);
-  if (index === -1) {
-    index = list.push(creator()) - 1;
-  }
-  return index;
-}
-
 /**
  * Pushes a pending note to the section content if it's not empty.
  * @param section - The current section object.

test/parser_helpers.test.ts

@@ -2,7 +2,6 @@ import { describe, it, expect, vi } from "vitest";
 import { Section as SectionObject } from "../src/classes/section";
 import type { Step, MetadataExtract, Cookware, Ingredient } from "../src/types";
 import {
-  findOrPush,
   flushPendingNote,
   flushPendingItems,
   parseSimpleMetaVar,
@@ -234,34 +233,6 @@ images: [https://static01.nyt.com/images/2021/12/28/dining/yf-baked-feta/yf-bake
   });
 });
 
-describe("findOrPush", () => {
-  it("should add an item if it does not exist and return its index", () => {
-    const list = [{ id: 1, name: "one" }];
-    const creator = vi.fn(() => ({ id: 2, name: "two" }));
-
-    const index = findOrPush(list, (item) => item.name === "two", creator);
-
-    expect(index).toBe(1);
-    expect(list).toHaveLength(2);
-    expect(list[1]).toEqual({ id: 2, name: "two" });
-    expect(creator).toHaveBeenCalledTimes(1);
-  });
-
-  it("should find an existing item and return its index without adding", () => {
-    const list = [
-      { id: 1, name: "one" },
-      { id: 2, name: "two" },
-    ];
-    const creator = vi.fn(() => ({ id: 3, name: "three" }));
-
-    const index = findOrPush(list, (item) => item.name === "two", creator);
-
-    expect(index).toBe(1);
-    expect(list).toHaveLength(2);
-    expect(creator).not.toHaveBeenCalled();
-  });
-});
-
 describe("flushPendingNote", () => {
   it("should add a note to the section if the note is not empty", () => {
     const section = new SectionObject("Test Section");