Merge pull request #112 from tmm1/private-attr-accessor

Fix crash in `private attr_reader :x`

Author: mislav

lib/ripper-tags/parser.rb

@@ -193,17 +193,21 @@ def on_method_add_arg(call, args)
         klass = name == access ? nil : 'self'
         procedure = :def_with_access
 
-        if args[1][0].is_a?(String)
-          procedure = :redefine_access
-          method_name = args[1][0]
+        if args[1][0].is_a?(Array)
+          args[1].inject([]) do |gen, def_args|
+            if def_args[1].is_a?(String)
+              gen << [procedure, klass, def_args[1], access, line]
+            else
+              gen
+            end
+          end
+        elsif args[1][0].is_a?(String)
+          [:redefine_access, klass, args[1][0], access, line]
         elsif args[1][1] == 'self'
-          method_name = args[1][2]
+          [procedure, klass, args[1][2], access, line]
         else
-          klass = nil
-          method_name = args[1][1]
+          [procedure, nil, args[1][1], access, line]
         end
-
-        [procedure, klass, method_name, access, line]
       when "module_function"
         access = "public"
         klass = "self"

test/test_ripper_tags.rb

@@ -203,6 +203,25 @@ def def() end
       assert_equal 'method',   tags.find{ |t| t[:name] == 'abc' }[:kind]
       assert_equal nil,        tags.find{ |t| t[:name] == 'def' }[:access]
     end
+    
+    %w(private public protected).each do |visibility|
+      tags = extract(<<-EOC)
+        class Test
+          #{visibility} attr_reader :a, :b
+          attr_reader :c
+        end
+      EOC
+
+      assert_equal 'a',        tags[1][:name]
+      assert_equal visibility, tags[1][:access]
+      assert_equal 'method',   tags[1][:kind]
+      assert_equal 'b',        tags[2][:name]
+      assert_equal visibility, tags[2][:access]
+      assert_equal 'method',   tags[2][:kind]
+      assert_equal 'c',        tags[3][:name]
+      assert_equal nil,        tags[3][:access]
+      assert_equal 'method',   tags[3][:kind]
+    end
 
     %w(private_class_method public_class_method).each do |visibility|
       tags = extract(<<-EOC)