Mark frames_buffer

peterzhu2118 · peterzhu2118 · commit c1f12ca76773 · 2023-04-05T11:38:58.000-04:00
Objects in frames_buffer may not have been placed the frames ST table
and may not be held on by Ruby meaning it could get garbage collected.
diff --git a/ext/stackprof/stackprof.c b/ext/stackprof/stackprof.c
@@ -811,6 +811,10 @@ stackprof_gc_mark(void *data)
 
     if (_stackprof.frames)
 	st_foreach(_stackprof.frames, frame_mark_i, 0);
+
+    for (int i = 0; i < _stackprof.buffer_count; i++) {
+        rb_gc_mark(_stackprof.frames_buffer[i]);
+    }
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -811,6 +811,10 @@ stackprof_gc_mark(void *data)`
`811`	`811`
`812`	`812`	`if (_stackprof.frames)`
`813`	`813`	`st_foreach(_stackprof.frames, frame_mark_i, 0);`
	`814`	`+`
	`815`	`+ for (int i = 0; i < _stackprof.buffer_count; i++) {`
	`816`	`+ rb_gc_mark(_stackprof.frames_buffer[i]);`
	`817`	`+ }`
`814`	`818`	`}`
`815`	`819`
`816`	`820`	`static void`