From 37e24607c2438c8227b8337e031918430662f774 Mon Sep 17 00:00:00 2001
From: S-H-GAMELINKS <gamelinks007@gmail.com>
Date: Wed, 14 May 2025 23:34:58 +0900
Subject: [PATCH] Drop support for Cucumber v1.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit removes support for Cucumber v1.3.

The last release of Cucumber v1.3 was nearly 10 years ago:
https://github.com/cucumber/cucumber-ruby/releases/tag/v1.3.20
It's hard to imagine anyone using such an old version of Cucumber with test-queue in 2025.

I’m also working on adding Ruby 3.4 support to CI for test-queue,
but running test-queue with Cucumber v1.3 on Ruby 3.4 is problematic:
https://github.com/S-H-GAMELINKS/test-queue/pull/1

Given these factors, I think it’s reasonable to drop support for Cucumber v1.3.
---
 .github/workflows/test.yml        |  1 -
 Appraisals                        |  6 ------
 gemfiles/cucumber1_3.gemfile      | 11 -----------
 lib/test_queue/runner/cucumber.rb |  6 +-----
 4 files changed, 1 insertion(+), 23 deletions(-)
 delete mode 100644 gemfiles/cucumber1_3.gemfile

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index b7d4dd8..8c5065a 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -21,7 +21,6 @@ jobs:
         # Lowest and Latest version.
         ruby: ['2.7', '3.3']
         entry:
-          - { name: cucumber1_3, bats: test/cucumber.bats }
           - { name: cucumber2_4, bats: test/cucumber.bats }
           - { name: minitest5, bats: test/minitest5.bats }
           - { name: rspec3, bats: test/rspec3.bats }
diff --git a/Appraisals b/Appraisals
index bbaa499..fe75bd5 100644
--- a/Appraisals
+++ b/Appraisals
@@ -1,11 +1,5 @@
 # frozen_string_literal: true
 
-appraise 'cucumber1-3' do
-  gem 'cucumber', '~> 1.3.10'
-  # Pin Rake version to Prevent `NoMethodError: undefined method `last_comment'`.
-  gem 'rake', '< 11.0'
-end
-
 appraise 'cucumber2-4' do
   gem 'cucumber', '~> 2.4.0'
   # Pin Rake version to Prevent `NoMethodError: undefined method `last_comment'`.
diff --git a/gemfiles/cucumber1_3.gemfile b/gemfiles/cucumber1_3.gemfile
deleted file mode 100644
index 387bfc5..0000000
--- a/gemfiles/cucumber1_3.gemfile
+++ /dev/null
@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'cucumber', '~> 1.3.10'
-gem 'rake', '< 11.0'
-gem 'rspec', '>= 2.13', '< 4.0'
-
-gemspec path: '../'
diff --git a/lib/test_queue/runner/cucumber.rb b/lib/test_queue/runner/cucumber.rb
index b314379..3482eeb 100644
--- a/lib/test_queue/runner/cucumber.rb
+++ b/lib/test_queue/runner/cucumber.rb
@@ -56,11 +56,7 @@ def run_worker(iterator)
 
         @test_framework.cli.execute!(runtime)
 
-        if runtime.respond_to?(:summary_report, true)
-          runtime.send(:summary_report).test_cases.total_failed
-        else
-          runtime.results.scenarios(:failed).size
-        end
+        runtime.send(:summary_report).test_cases.total_failed
       end
 
       def summarize_worker(worker)