Have removed all explicit class constraints and nothing blows up (#295)

All the unit tests still pass, however I have not added anything to them as there are loads of them and I don't want to go down the rabbit hole of verifying all same tests but with structs, also didn't run integration tests.

However it's a start incase anyone else wants to pick it up.

Author: grofit

DapperExtensions.Test/Mapper/AutoClassMapperFixture.cs

@@ -91,7 +91,7 @@ public void Sets_IdFirstPropertyEndingInIdWhenNoIdPropertyFound()
                 Assert.IsTrue(map.ColumnName == "SomeId");
             }
 
-            private static AutoClassMapper<T> GetMapper<T>() where T : class
+            private static AutoClassMapper<T> GetMapper<T>()
             {
                 return new AutoClassMapper<T>();
             }
@@ -114,12 +114,12 @@ public void ReturnsProperResultsForExceptions()
                 Assert.AreEqual("TheFoo", m.TableName);
             }
 
-            private static CustomAutoMapper<T> GetMapper<T>() where T : class
+            private static CustomAutoMapper<T> GetMapper<T>()
             {
                 return new CustomAutoMapper<T>();
             }
 
-            public class CustomAutoMapper<T> : AutoClassMapper<T> where T : class
+            public class CustomAutoMapper<T> : AutoClassMapper<T>
             {
                 public override void Table(string tableName)
                 {

DapperExtensions.Test/Mapper/ClassMapperFixture.cs

@@ -23,7 +23,7 @@ public void Setup()
             {
             }
 
-            protected ClassMapper<T> GetMapper<T>() where T : class
+            protected ClassMapper<T> GetMapper<T>()
             {
                 return new ClassMapper<T>();
             }
@@ -400,7 +400,7 @@ public class Bar
         }
 
         [ExcludeFromCodeCoverage]
-        public class TestMapper<T> : ClassMapper<T> where T : class
+        public class TestMapper<T> : ClassMapper<T>
         {
             public new MemberMap Map(Expression<Func<T, object>> expression)
             {

DapperExtensions.Test/Mapper/PluralizedAutoClassMapperFixture.cs

@@ -75,7 +75,7 @@ public void ReturnsProperPluralizationWhenWordIsUnpluralizable()
                 Assert.AreEqual("equipment", m.TableName);
             }
 
-            private static PluralizedAutoClassMapper<T> GetMapper<T>() where T : class
+            private static PluralizedAutoClassMapper<T> GetMapper<T>()
             {
                 return new PluralizedAutoClassMapper<T>();
             }
@@ -100,12 +100,12 @@ public void ReturnsProperResultsForExceptions()
                 Assert.AreEqual("People", m.TableName);
             }
 
-            private static CustomPluralizedMapper<T> GetMapper<T>() where T : class
+            private static CustomPluralizedMapper<T> GetMapper<T>()
             {
                 return new CustomPluralizedMapper<T>();
             }
 
-            public class CustomPluralizedMapper<T> : PluralizedAutoClassMapper<T> where T : class
+            public class CustomPluralizedMapper<T> : PluralizedAutoClassMapper<T>
             {
                 public override void Table(string tableName)
                 {

DapperExtensions.Test/PredicatesFixture.cs

@@ -147,16 +147,16 @@ public void In_ReturnsSetupPredicate()
                 Assert.AreEqual("Id", predicate.PropertyName);
                 Assert.AreEqual(values, predicate.Collection);
                 Assert.AreEqual(false, predicate.Not);
-            }
-
+            }
+
             [Test]
             public void BitEq_ReturnsSetupPredicate()
             {
                 var predicate = Predicates.Field<PredicateTestEntity>(f => f.Id, Operator.BitEq, 1, false);
                 Assert.AreEqual("Id", predicate.PropertyName);
                 Assert.AreEqual(Operator.BitEq, predicate.Operator);
                 Assert.AreEqual(1, predicate.Value);
-                Assert.AreEqual(false, predicate.Not);
+                Assert.AreEqual(false, predicate.Not);
             }
         }
 
@@ -392,7 +392,7 @@ public void GetSql_ChainedProperty_ReturnsProperSql()
                 sql.Should().Be("(y2.Id ** @Id_0)");
             }
 
-            protected Mock<FieldPredicate<T>> Setup<T>(string propertyName, Operator op, object value, bool not, DatabaseFunction databaseFunction = DatabaseFunction.None, string functionParameters = null) where T : class
+            protected Mock<FieldPredicate<T>> Setup<T>(string propertyName, Operator op, object value, bool not, DatabaseFunction databaseFunction = DatabaseFunction.None, string functionParameters = null)
             {
                 Configuration.Setup(m => m.GetMap(It.IsAny<Type>())).Returns(new AutoClassMapper<T>());
 
@@ -483,7 +483,7 @@ public void GetSql_BothtPropertyWithDatabaseFunction_ReturnsProperSql()
             protected Mock<PropertyPredicate<T, T2>> Setup<T, T2>(string propertyName, Operator op, string propertyName2, bool not, 
                 DatabaseFunction leftDatabaseFunction = DatabaseFunction.None, string leftFunctionParameters = null,
                 DatabaseFunction rightDatabaseFunction = DatabaseFunction.None, string rightFunctionParameters = null)
-                where T : class
+               
                 where T2 : class
             {
                 Mock<PropertyPredicate<T, T2>> predicate = new Mock<PropertyPredicate<T, T2>>();
@@ -539,7 +539,7 @@ public void GetSql_Not_ReturnsProperSql()
             }
 
             protected Mock<BetweenPredicate<T>> Setup<T>(string propertyName, object value1, object value2, bool not)
-                where T : class
+               
             {
                 Configuration.Setup(m => m.GetMap(It.IsAny<Type>())).Returns(new AutoClassMapper<T>());
 
@@ -706,7 +706,7 @@ public void GetClassMapper_ReturnsMap()
                 Assert.AreEqual(classMap.Object, result);
             }
 
-            protected Mock<ExistsPredicate<T>> Setup<T>(IPredicate predicate, IClassMapper classMap, bool not) where T : class
+            protected Mock<ExistsPredicate<T>> Setup<T>(IPredicate predicate, IClassMapper classMap, bool not)
             {
                 Configuration.Setup(m => m.GetMap(It.IsAny<Type>())).Returns(new AutoClassMapper<T>());
 
@@ -759,7 +759,7 @@ public void GetSql_Not_ReturnsProperSql()
             }
 
             protected Mock<InPredicate<T>> Setup<T>(string propertyName, bool not, params long[] values)
-                where T : class
+               
             {
                 Configuration.Setup(m => m.GetMap(It.IsAny<Type>())).Returns(new AutoClassMapper<T>());
 

DapperExtensions/DapperAsyncExtensions.cs

@@ -161,7 +161,7 @@ public static IDapperExtensionsConfiguration Configure(this Type defaultMapper,
         /// <summary>
         /// Executes a query using the specified predicate, returning an integer that represents the number of rows that match the query.
         /// </summary>
-        public static async Task<int> CountAsync<T>(this IDbConnection connection, object predicate = null, IDbTransaction transaction = null, int? commandTimeout = null) where T : class
+        public static async Task<int> CountAsync<T>(this IDbConnection connection, object predicate = null, IDbTransaction transaction = null, int? commandTimeout = null)
         {
             return await Instance.CountAsync<T>(connection, predicate, transaction, commandTimeout).ConfigureAwait(false);
         }
@@ -170,7 +170,7 @@ public static async Task<int> CountAsync<T>(this IDbConnection connection, objec
         /// Executes a query for the specified id, returning the data typed as per T.
         /// </summary>
         public static async Task<T> GetAsync<T>(this IDbConnection connection, dynamic id, IDbTransaction transaction = null,
-            int? commandTimeout = null, bool buffered = false) where T : class
+            int? commandTimeout = null, bool buffered = false)
         {
             return await Instance.GetAsync<T>(connection, id, transaction, commandTimeout, buffered, null).ConfigureAwait(false);
         }
@@ -192,7 +192,7 @@ public static async Task<TOut> GetPartialAsync<TIn, TOut>(this IDbConnection con
         /// Executes a select query using the specified predicate, returning an IEnumerable data typed as per T.
         /// </summary>
         public static async Task<IEnumerable<T>> GetListAsync<T>(this IDbConnection connection, object predicate = null, IList<ISort> sort = null,
-            IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false) where T : class
+            IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false)
         {
             return await Instance.GetListAsync<T>(connection, predicate, sort, transaction, commandTimeout, buffered, null).ConfigureAwait(false);
         }
@@ -214,15 +214,15 @@ public static async Task<IEnumerable<TOut>> GetPartialListAsync<TIn, TOut>(this
         /// Contains Slapper.Automaper
         /// </summary>
         public static async Task<IEnumerable<T>> GetListAutoMapAsync<T>(this IDbConnection connection, object predicate = null, IList<ISort> sort = null,
-            IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false, IList<IProjection> colsToSelect = null) where T : class
+            IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false, IList<IProjection> colsToSelect = null)
         {
             return await Instance.GetListAutoMapAsync<T>(connection, predicate, sort, transaction, commandTimeout, buffered, colsToSelect).ConfigureAwait(false);
         }
 
         /// <summary>
         /// Executes an insert query for the specified entity.
         /// </summary>
-        public static Task InsertAsync<T>(this IDbConnection connection, IEnumerable<T> entities, IDbTransaction transaction = null, int? commandTimeout = default) where T : class
+        public static Task InsertAsync<T>(this IDbConnection connection, IEnumerable<T> entities, IDbTransaction transaction = null, int? commandTimeout = default)
         {
             return Instance.InsertAsync(connection, entities, transaction, commandTimeout);
         }
@@ -233,7 +233,7 @@ public static Task InsertAsync<T>(this IDbConnection connection, IEnumerable<T>
         /// If the entity has a composite key, an IDictionary&lt;string, object&gt; is returned with the key values.
         /// The key value for the entity will also be updated if the KeyType is a Guid or Identity.
         /// </summary>
-        public static Task<dynamic> InsertAsync<T>(this IDbConnection connection, T entity, IDbTransaction transaction = null, int? commandTimeout = default) where T : class
+        public static Task<dynamic> InsertAsync<T>(this IDbConnection connection, T entity, IDbTransaction transaction = null, int? commandTimeout = default)
         {
             return Instance.InsertAsync(connection, entity, transaction, commandTimeout);
         }
@@ -242,7 +242,7 @@ public static Task<dynamic> InsertAsync<T>(this IDbConnection connection, T enti
         /// Executes an update query for the specified entity.
         /// </summary>
         public static Task<bool> UpdateAsync<T>(this IDbConnection connection, T entity, IDbTransaction transaction = null,
-            int? commandTimeout = null, bool ignoreAllKeyProperties = false) where T : class
+            int? commandTimeout = null, bool ignoreAllKeyProperties = false)
         {
             return Instance.UpdateAsync(connection, entity, transaction, commandTimeout, ignoreAllKeyProperties, null);
         }
@@ -260,15 +260,15 @@ public static Task<bool> UpdatePartialAsync<TIn, TOut>(this IDbConnection connec
         /// <summary>
         /// Executes a delete query for the specified entity.
         /// </summary>
-        public static Task<bool> DeleteAsync<T>(this IDbConnection connection, T entity, IDbTransaction transaction = null, int? commandTimeout = null) where T : class
+        public static Task<bool> DeleteAsync<T>(this IDbConnection connection, T entity, IDbTransaction transaction = null, int? commandTimeout = null)
         {
             return Instance.DeleteAsync(connection, entity, transaction, commandTimeout);
         }
 
         /// <summary>
         /// Executes a delete query using the specified predicate.
         /// </summary>
-        public static Task<bool> DeleteAsync<T>(this IDbConnection connection, object predicate, IDbTransaction transaction = null, int? commandTimeout = null) where T : class
+        public static Task<bool> DeleteAsync<T>(this IDbConnection connection, object predicate, IDbTransaction transaction = null, int? commandTimeout = null)
         {
             return Instance.DeleteAsync(connection, predicate, transaction, commandTimeout);
         }
@@ -278,7 +278,7 @@ public static Task<bool> DeleteAsync<T>(this IDbConnection connection, object pr
         /// Data returned is dependent upon the specified page and resultsPerPage.
         /// </summary>
         public static async Task<IEnumerable<T>> GetPageAsync<T>(this IDbConnection connection, object predicate = null, IList<ISort> sort = null, int page = 1,
-            int resultsPerPage = 10, IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false) where T : class
+            int resultsPerPage = 10, IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false)
         {
             return await Instance.GetPageAsync<T>(connection, predicate, sort, page, resultsPerPage, transaction, commandTimeout, buffered, null).ConfigureAwait(false);
         }
@@ -307,7 +307,7 @@ public static async Task<IEnumerable<TOut>> GetPartialPageAsync<TIn, TOut>(this
         /// Contains Slapper.Automaper
         /// </summary>
         public static async Task<IEnumerable<T>> GetPageAutoMapAsync<T>(this IDbConnection connection, object predicate = null, IList<ISort> sort = null, int page = 1,
-            int resultsPerPage = 10, IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false, IList<IProjection> colsToSelect = null) where T : class
+            int resultsPerPage = 10, IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false, IList<IProjection> colsToSelect = null)
         {
             return await Instance.GetPageAutoMapAsync<T>(connection, predicate, sort, page, resultsPerPage, transaction, commandTimeout, buffered, colsToSelect).ConfigureAwait(false);
         }
@@ -317,7 +317,7 @@ public static async Task<IEnumerable<T>> GetPageAutoMapAsync<T>(this IDbConnecti
         /// Data returned is dependent upon the specified firstResult and maxResults.
         /// </summary>
         public static async Task<IEnumerable<T>> GetSetAsync<T>(this IDbConnection connection, object predicate = null, IList<ISort> sort = null, int firstResult = 1,
-            int maxResults = 10, IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false) where T : class
+            int maxResults = 10, IDbTransaction transaction = null, int? commandTimeout = null, bool buffered = false)
         {
             return await Instance.GetSetAsync<T>(connection, predicate, sort, firstResult, maxResults, transaction, commandTimeout, buffered, null).ConfigureAwait(false);
         }
@@ -367,7 +367,7 @@ public static async Task<Guid> GetNextGuid()
         /// Gets the appropriate mapper for the specified type T.
         /// If the mapper for the type is not yet created, a new mapper is generated from the mapper type specifed by DefaultMapper.
         /// </summary>
-        public static async Task<IClassMapper> GetMap<T>() where T : class
+        public static async Task<IClassMapper> GetMap<T>()
         {
             return await Task.FromResult(_configuration.GetMap<T>());
         }