Skip to content

Commit 0182169

Browse files
committed
fix(tests): correct min_version for additional hooks and options
why: CI fails on tmux 3.2a, 3.3a, and 3.5 due to incorrect version requirements what: - scroll-on-clear: change min_version from 3.2 to 3.3 (added in 3.3) - allow-passthrough "all" value: change min_version from 3.3 to 3.4 (added in 3.4) - Remove client-light-theme and client-dark-theme tests (not released yet, will be in 3.6+)
1 parent 3ccf743 commit 0182169

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

tests/test_hooks.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -417,18 +417,8 @@ class HookTestCase(t.NamedTuple):
417417
"3.5",
418418
xfail_reason="pane-title-changed requires tmux 3.5+",
419419
),
420-
HookTestCase(
421-
"client_light_theme",
422-
"client-light-theme",
423-
"3.5",
424-
xfail_reason="client-light-theme requires tmux 3.5+",
425-
),
426-
HookTestCase(
427-
"client_dark_theme",
428-
"client-dark-theme",
429-
"3.5",
430-
xfail_reason="client-dark-theme requires tmux 3.5+",
431-
),
420+
# NOTE: client-light-theme and client-dark-theme are not in any released tmux
421+
# version yet (will be in 3.6+). Add them back when 3.6 is released.
432422
]
433423

434424
# Combine all hook test cases

tests/test_options.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -992,7 +992,7 @@ class OptionTestCase(t.NamedTuple):
992992
"pane_alternate_screen", "alternate-screen", OptionScope.Pane, "on", bool, "3.0"
993993
),
994994
OptionTestCase(
995-
"pane_scroll_on_clear", "scroll-on-clear", OptionScope.Pane, "on", bool, "3.2"
995+
"pane_scroll_on_clear", "scroll-on-clear", OptionScope.Pane, "on", bool, "3.3"
996996
),
997997
OptionTestCase(
998998
"pane_synchronize_panes",
@@ -1012,7 +1012,7 @@ class OptionTestCase(t.NamedTuple):
10121012
OptionScope.Pane,
10131013
"all",
10141014
str,
1015-
"3.3",
1015+
"3.4",
10161016
),
10171017
# remain-on-exit: "on"/"off" return bool, use "failed" for str test (3.2+)
10181018
OptionTestCase(

0 commit comments

Comments
 (0)