Skip to content

Commit 340568c

Browse files
committed
!squash fix: rename _global to global_ in base HooksMixin
why: Python convention uses trailing underscore (global_) to avoid conflicts with reserved words, not leading underscore (_global). what: - Rename _global to global_ in set_hook, unset_hook, show_hooks - Rename _global to global_ in _show_hook, show_hook
1 parent be70aa0 commit 340568c

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/libtmux/hooks.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def set_hook(
122122
ignore_errors: bool | None = None,
123123
append: bool | None = None,
124124
g: bool | None = None,
125-
_global: bool | None = None,
125+
global_: bool | None = None,
126126
scope: OptionScope | _DefaultOptionScope | None = DEFAULT_OPTION_SCOPE,
127127
) -> Self:
128128
"""Set hook for tmux target.
@@ -170,8 +170,8 @@ def set_hook(
170170
assert isinstance(append, bool)
171171
flags.append("-a")
172172

173-
if _global is not None and _global:
174-
assert isinstance(_global, bool)
173+
if global_ is not None and global_:
174+
assert isinstance(global_, bool)
175175
flags.append("-g")
176176

177177
if scope is not None and not isinstance(scope, _DefaultOptionScope):
@@ -201,7 +201,7 @@ def set_hook(
201201
def unset_hook(
202202
self,
203203
hook: str,
204-
_global: bool | None = None,
204+
global_: bool | None = None,
205205
ignore_errors: bool | None = None,
206206
scope: OptionScope | _DefaultOptionScope | None = DEFAULT_OPTION_SCOPE,
207207
) -> Self:
@@ -228,8 +228,8 @@ def unset_hook(
228228
assert isinstance(ignore_errors, bool)
229229
flags.append("-q")
230230

231-
if _global is not None and _global:
232-
assert isinstance(_global, bool)
231+
if global_ is not None and global_:
232+
assert isinstance(global_, bool)
233233
flags.append("-g")
234234

235235
if scope is not None and not isinstance(scope, _DefaultOptionScope):
@@ -257,7 +257,7 @@ def unset_hook(
257257

258258
def show_hooks(
259259
self,
260-
_global: bool | None = False,
260+
global_: bool | None = False,
261261
scope: OptionScope | _DefaultOptionScope | None = DEFAULT_OPTION_SCOPE,
262262
ignore_errors: bool | None = None,
263263
) -> HookDict:
@@ -267,7 +267,7 @@ def show_hooks(
267267

268268
flags: tuple[str, ...] = ()
269269

270-
if _global:
270+
if global_:
271271
flags += ("-g",)
272272

273273
if scope is not None and not isinstance(scope, _DefaultOptionScope):
@@ -306,7 +306,7 @@ def show_hooks(
306306
def _show_hook(
307307
self,
308308
hook: str,
309-
_global: bool = False,
309+
global_: bool = False,
310310
scope: OptionScope | _DefaultOptionScope | None = DEFAULT_OPTION_SCOPE,
311311
ignore_errors: bool | None = None,
312312
) -> list[str] | None:
@@ -326,7 +326,7 @@ def _show_hook(
326326

327327
flags: tuple[str | int, ...] = ()
328328

329-
if _global:
329+
if global_:
330330
flags += ("-g",)
331331

332332
if scope is not None and not isinstance(scope, _DefaultOptionScope):
@@ -356,7 +356,7 @@ def _show_hook(
356356
def show_hook(
357357
self,
358358
hook: str,
359-
_global: bool = False,
359+
global_: bool = False,
360360
scope: OptionScope | _DefaultOptionScope | None = DEFAULT_OPTION_SCOPE,
361361
ignore_errors: bool | None = None,
362362
) -> str | int | None:

0 commit comments

Comments
 (0)