hooks(fix[show_hooks]): Store string hook values in returned dict

why: show_hooks() only stored values when val.isdigit() was True,
silently dropping all string hook values (the common case for tmux hooks).
what:
- Fix parsing to split on first whitespace only (handles multi-word values)
- Remove unused shlex import
- Add docstring with Parameters, Returns, and Examples sections
- Add parametrized test with NamedTuple for show_hooks string values

Author: tony

src/libtmux/hooks.py

@@ -30,7 +30,6 @@
 from __future__ import annotations
 
 import logging
-import shlex
 import typing as t
 import warnings
 
@@ -254,7 +253,37 @@ def show_hooks(
         scope: OptionScope | _DefaultOptionScope | None = DEFAULT_OPTION_SCOPE,
         ignore_errors: bool | None = None,
     ) -> HookDict:
-        """Return a dict of hooks for the target."""
+        """Return a dict of hooks for the target.
+
+        Parameters
+        ----------
+        global_ : bool, optional
+            Pass ``-g`` flag for global hooks, default False.
+        scope : OptionScope | _DefaultOptionScope | None, optional
+            Hook scope (Server/Session/Window/Pane), defaults to object's scope.
+        ignore_errors : bool, optional
+            Suppress errors with ``-q`` flag.
+
+        Returns
+        -------
+        HookDict
+            Dictionary mapping hook names to their values.
+
+        Examples
+        --------
+        >>> session.set_hook('session-renamed[0]', 'display-message "test"')
+        Session($...)
+
+        >>> hooks = session.show_hooks()
+        >>> isinstance(hooks, dict)
+        True
+
+        >>> 'session-renamed[0]' in hooks
+        True
+
+        >>> session.unset_hook('session-renamed')
+        Session($...)
+        """
         if scope is DEFAULT_OPTION_SCOPE:
             scope = self.default_hook_scope
 
@@ -283,16 +312,20 @@ def show_hooks(
         output = cmd.stdout
         hooks: HookDict = {}
         for item in output:
-            try:
-                key, val = shlex.split(item)
-            except ValueError:
+            # Split on first whitespace only to handle multi-word hook values
+            parts = item.split(None, 1)
+            if len(parts) == 2:
+                key, val = parts
+            elif len(parts) == 1:
+                key, val = parts[0], None
+            else:
                 logger.warning(f"Error extracting hook: {item}")
-                key, val = item, None
-            assert isinstance(key, str)
-            assert isinstance(val, str) or val is None
+                continue
 
             if isinstance(val, str) and val.isdigit():
                 hooks[key] = int(val)
+            elif isinstance(val, str):
+                hooks[key] = val
 
         return hooks
 

tests/test_hooks.py

@@ -712,3 +712,64 @@ def test_set_hook_append_flag(server: Server) -> None:
 
     # Cleanup
     session.unset_hook("session-renamed")
+
+
+# =============================================================================
+# show_hooks Tests
+# =============================================================================
+
+
+class ShowHooksTestCase(t.NamedTuple):
+    """Test case for show_hooks validation."""
+
+    test_id: str
+    hook: str
+    value: str
+    expected_value: str
+    expected_type: type
+    min_version: str = "3.2"
+
+
+SHOW_HOOKS_TEST_CASES: list[ShowHooksTestCase] = [
+    ShowHooksTestCase(
+        test_id="string_hook_value",
+        hook="session-renamed[0]",
+        value='display-message "test"',
+        expected_value="display-message test",  # tmux strips quotes in output
+        expected_type=str,
+    ),
+    ShowHooksTestCase(
+        test_id="multiple_hooks",
+        hook="session-renamed[1]",
+        value='display-message "another"',
+        expected_value="display-message another",  # tmux strips quotes in output
+        expected_type=str,
+    ),
+]
+
+
+def _build_show_hooks_params() -> list[t.Any]:
+    """Build pytest params for show_hooks tests."""
+    return [pytest.param(tc, id=tc.test_id) for tc in SHOW_HOOKS_TEST_CASES]
+
+
+@pytest.mark.parametrize("test_case", _build_show_hooks_params())
+def test_show_hooks_stores_string_values(
+    server: Server,
+    test_case: ShowHooksTestCase,
+) -> None:
+    """Test that show_hooks() correctly stores string hook values."""
+    if not has_gte_version(test_case.min_version):
+        pytest.skip(f"Requires tmux >= {test_case.min_version}")
+
+    session = server.new_session(session_name="test_show_hooks")
+
+    session.set_hook(test_case.hook, test_case.value)
+    hooks = session.show_hooks()
+
+    assert test_case.hook in hooks
+    assert isinstance(hooks[test_case.hook], test_case.expected_type)
+    assert hooks[test_case.hook] == test_case.expected_value
+
+    # Cleanup
+    session.unset_hook(test_case.hook.split("[")[0])