Stop archiving ChannelMonitors

.. as this is now done by the background processor.

Author: tnull

bindings/ldk_node.udl

@@ -359,7 +359,6 @@ dictionary NodeStatus {
 	u64? latest_rgs_snapshot_timestamp;
 	u64? latest_pathfinding_scores_sync_timestamp;
 	u64? latest_node_announcement_broadcast_timestamp;
-	u32? latest_channel_monitor_archival_height;
 };
 
 dictionary BestBlock {

src/chain/bitcoind.rs

@@ -29,7 +29,7 @@ use lightning_block_sync::{
 };
 use serde::Serialize;
 
-use super::{periodically_archive_fully_resolved_monitors, WalletSyncStatus};
+use super::WalletSyncStatus;
 use crate::config::{
 	BitcoindRestClientConfig, Config, FEE_RATE_CACHE_UPDATE_TIMEOUT_SECS, TX_BROADCAST_TIMEOUT_SECS,
 };
@@ -414,14 +414,6 @@ impl BitcoindChainSource {
 					now.elapsed().unwrap().as_millis()
 				);
 				*self.latest_chain_tip.write().unwrap() = Some(tip);
-
-				periodically_archive_fully_resolved_monitors(
-					&*channel_manager,
-					&*chain_monitor,
-					&*self.kv_store,
-					&*self.logger,
-					&*self.node_metrics,
-				)?;
 			},
 			Ok(_) => {},
 			Err(e) => {

src/chain/electrum.rs

@@ -23,7 +23,7 @@ use lightning::chain::{Confirm, Filter, WatchedOutput};
 use lightning::util::ser::Writeable;
 use lightning_transaction_sync::ElectrumSyncClient;
 
-use super::{periodically_archive_fully_resolved_monitors, WalletSyncStatus};
+use super::WalletSyncStatus;
 use crate::config::{
 	Config, ElectrumSyncConfig, BDK_CLIENT_STOP_GAP, BDK_WALLET_SYNC_TIMEOUT_SECS,
 	FEE_RATE_CACHE_UPDATE_TIMEOUT_SECS, LDK_WALLET_SYNC_TIMEOUT_SECS, TX_BROADCAST_TIMEOUT_SECS,
@@ -241,14 +241,6 @@ impl ElectrumChainSource {
 				locked_node_metrics.latest_lightning_wallet_sync_timestamp = unix_time_secs_opt;
 				write_node_metrics(&*locked_node_metrics, &*self.kv_store, &*self.logger)?;
 			}
-
-			periodically_archive_fully_resolved_monitors(
-				&*channel_manager,
-				&*chain_monitor,
-				&*self.kv_store,
-				&*self.logger,
-				&*self.node_metrics,
-			)?;
 		}
 
 		res

src/chain/esplora.rs

@@ -16,7 +16,7 @@ use lightning::chain::{Confirm, Filter, WatchedOutput};
 use lightning::util::ser::Writeable;
 use lightning_transaction_sync::EsploraSyncClient;
 
-use super::{periodically_archive_fully_resolved_monitors, WalletSyncStatus};
+use super::WalletSyncStatus;
 use crate::config::{
 	Config, EsploraSyncConfig, BDK_CLIENT_CONCURRENCY, BDK_CLIENT_STOP_GAP,
 	BDK_WALLET_SYNC_TIMEOUT_SECS, DEFAULT_ESPLORA_CLIENT_TIMEOUT_SECS,
@@ -261,14 +261,6 @@ impl EsploraChainSource {
 							unix_time_secs_opt;
 						write_node_metrics(&*locked_node_metrics, &*self.kv_store, &*self.logger)?;
 					}
-
-					periodically_archive_fully_resolved_monitors(
-						&*channel_manager,
-						&*chain_monitor,
-						&*self.kv_store,
-						&*self.logger,
-						&*self.node_metrics,
-					)?;
 					Ok(())
 				},
 				Err(e) => {

src/chain/mod.rs

@@ -21,10 +21,9 @@ use crate::chain::electrum::ElectrumChainSource;
 use crate::chain::esplora::EsploraChainSource;
 use crate::config::{
 	BackgroundSyncConfig, BitcoindRestClientConfig, Config, ElectrumSyncConfig, EsploraSyncConfig,
-	RESOLVED_CHANNEL_MONITOR_ARCHIVAL_INTERVAL, WALLET_SYNC_INTERVAL_MINIMUM_SECS,
+	WALLET_SYNC_INTERVAL_MINIMUM_SECS,
 };
 use crate::fee_estimator::OnchainFeeEstimator;
-use crate::io::utils::write_node_metrics;
 use crate::logger::{log_debug, log_info, log_trace, LdkLogger, Logger};
 use crate::runtime::Runtime;
 use crate::types::{Broadcaster, ChainMonitor, ChannelManager, DynStore, Sweeper, Wallet};
@@ -486,22 +485,3 @@ impl Filter for ChainSource {
 		}
 	}
 }
-
-fn periodically_archive_fully_resolved_monitors(
-	channel_manager: &ChannelManager, chain_monitor: &ChainMonitor, kv_store: &DynStore,
-	logger: &Logger, node_metrics: &RwLock<NodeMetrics>,
-) -> Result<(), Error> {
-	let mut locked_node_metrics = node_metrics.write().unwrap();
-	let cur_height = channel_manager.current_best_block().height;
-	let should_archive = locked_node_metrics
-		.latest_channel_monitor_archival_height
-		.as_ref()
-		.map_or(true, |h| cur_height >= h + RESOLVED_CHANNEL_MONITOR_ARCHIVAL_INTERVAL);
-
-	if should_archive {
-		chain_monitor.archive_fully_resolved_channel_monitors();
-		locked_node_metrics.latest_channel_monitor_archival_height = Some(cur_height);
-		write_node_metrics(&*locked_node_metrics, kv_store, logger)?;
-	}
-	Ok(())
-}

src/config.rs

@@ -54,9 +54,6 @@ pub(crate) const BDK_CLIENT_CONCURRENCY: usize = 4;
 // The timeout after which we abandon retrying failed payments.
 pub(crate) const LDK_PAYMENT_RETRY_TIMEOUT: Duration = Duration::from_secs(10);
 
-// The interval (in block height) after which we retry archiving fully resolved channel monitors.
-pub(crate) const RESOLVED_CHANNEL_MONITOR_ARCHIVAL_INTERVAL: u32 = 6;
-
 // The time in-between peer reconnection attempts.
 pub(crate) const PEER_RECONNECTION_INTERVAL: Duration = Duration::from_secs(60);
 

src/lib.rs

@@ -728,8 +728,6 @@ impl Node {
 			locked_node_metrics.latest_pathfinding_scores_sync_timestamp;
 		let latest_node_announcement_broadcast_timestamp =
 			locked_node_metrics.latest_node_announcement_broadcast_timestamp;
-		let latest_channel_monitor_archival_height =
-			locked_node_metrics.latest_channel_monitor_archival_height;
 
 		NodeStatus {
 			is_running,
@@ -740,7 +738,6 @@ impl Node {
 			latest_rgs_snapshot_timestamp,
 			latest_pathfinding_scores_sync_timestamp,
 			latest_node_announcement_broadcast_timestamp,
-			latest_channel_monitor_archival_height,
 		}
 	}
 
@@ -1806,10 +1803,6 @@ pub struct NodeStatus {
 	///
 	/// Will be `None` if we have no public channels or we haven't broadcasted yet.
 	pub latest_node_announcement_broadcast_timestamp: Option<u64>,
-	/// The block height when we last archived closed channel monitor data.
-	///
-	/// Will be `None` if we haven't archived any monitors of closed channels yet.
-	pub latest_channel_monitor_archival_height: Option<u32>,
 }
 
 /// Status fields that are persisted across restarts.
@@ -1821,7 +1814,6 @@ pub(crate) struct NodeMetrics {
 	latest_rgs_snapshot_timestamp: Option<u32>,
 	latest_pathfinding_scores_sync_timestamp: Option<u64>,
 	latest_node_announcement_broadcast_timestamp: Option<u64>,
-	latest_channel_monitor_archival_height: Option<u32>,
 }
 
 impl Default for NodeMetrics {
@@ -1833,7 +1825,6 @@ impl Default for NodeMetrics {
 			latest_rgs_snapshot_timestamp: None,
 			latest_pathfinding_scores_sync_timestamp: None,
 			latest_node_announcement_broadcast_timestamp: None,
-			latest_channel_monitor_archival_height: None,
 		}
 	}
 }
@@ -1845,7 +1836,8 @@ impl_writeable_tlv_based!(NodeMetrics, {
 	(4, latest_fee_rate_cache_update_timestamp, option),
 	(6, latest_rgs_snapshot_timestamp, option),
 	(8, latest_node_announcement_broadcast_timestamp, option),
-	(10, latest_channel_monitor_archival_height, option),
+	// 10 used to be latest_channel_monitor_archival_height
+	(10, _legacy_latest_channel_monitor_archival_height, (legacy, Option<u32>, |_: &NodeMetrics| None::<Option<u32>> )),
 });
 
 pub(crate) fn total_anchor_channels_reserve_sats(