Skip to content

IncludeDataSource: false seems broken #62

@rick-weyrauch-lol

Description

@rick-weyrauch-lol

I am not sure how "IncludeDataSource: false" is able to work for anyone. I am not a PowerShell expert, but when I look at this if:

if($IncludeDataSource -eq $true)

... it's not right since $IncludeDataSource is a string in the PS:

[string]$IncludeDataSource,

... and so both 'false' and 'true' -eq to $true, and causes the run to display this error (which actually makes sense based on the Write-Error code inside the if):

Uploading files
##[error]Microsoft.PowerShell.Commands.WriteErrorException: No file(s) matching the path/wildcard False were found
##[error]PowerShell script completed with 1 errors.
##########################################################
#                      Testing files                     #
##########################################################

	Write-Host "Uploading files" -NoNewline;
	#Get all Files using the $ReportFiles parameter (expecting it is a Wildcard or direct link to 1 file)
	$pathIsValid = Test-Path $ReportFiles;
	if($pathIsValid -eq $False){
		Write-Error "No file(s) matching the path/wildcard $ReportFiles were found";#NotFound 1
		exit -1;
	}

	if($IncludeDataSource -eq $true){
		$pathRdsIsValid = Test-Path $DataSourceLocalPath;
		if($pathRdsIsValid -eq $false){
			Write-Error "No file(s) matching the path/wildcard $pathRdsIsValid were found";#NotFound 1
			exit -1;
		}
	}

I need to be able to run without deploying Data Sources - any chance that can get fixed? Is this tool still being maintained?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions