Skip to content

Commit 060ecfc

Browse files
authored
Fix: don't generate comments in table_name (#4375)
1 parent 4d3904e commit 060ecfc

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

sqlglot/expressions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8105,7 +8105,7 @@ def table_name(table: Table | str, dialect: DialectType = None, identify: bool =
81058105

81068106
return ".".join(
81078107
(
8108-
part.sql(dialect=dialect, identify=True, copy=False)
8108+
part.sql(dialect=dialect, identify=True, copy=False, comments=False)
81098109
if identify or not SAFE_IDENTIFIER_RE.match(part.name)
81108110
else part.name
81118111
)

tests/test_expressions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,14 @@ def test_table_name(self):
216216
self.assertEqual(exp.table_name(exp.to_table("a.b.c.d.e", dialect="bigquery")), "a.b.c.d.e")
217217
self.assertEqual(exp.table_name(exp.to_table("'@foo'", dialect="snowflake")), "'@foo'")
218218
self.assertEqual(exp.table_name(exp.to_table("@foo", dialect="snowflake")), "@foo")
219+
self.assertEqual(exp.table_name(bq_dashed_table, identify=True), '"a-1"."b"."c"')
219220
self.assertEqual(
220221
exp.table_name(parse_one("foo.`{bar,er}`", read="databricks"), dialect="databricks"),
221222
"foo.`{bar,er}`",
222223
)
223-
224-
self.assertEqual(exp.table_name(bq_dashed_table, identify=True), '"a-1"."b"."c"')
224+
self.assertEqual(
225+
exp.table_name(parse_one("/*c*/foo.bar", into=exp.Table), identify=True), '"foo"."bar"'
226+
)
225227

226228
def test_table(self):
227229
self.assertEqual(exp.table_("a", alias="b"), parse_one("select * from a b").find(exp.Table))

0 commit comments

Comments
 (0)