Skip to content

Commit 1502316

Browse files
NickCrewsgeorgesittas
authored andcommitted
fix(trino): mark as supporting ...EXCEPT ALL (#6616)
This is for `SELECT * FROM t1 INTERSECT/EXCEPT ALL SELECT * FROM t2` Trino inherits the dialect from Presto. Presto doesn't support the `ALL` modifier, but trino does, see trinodb/trino#5890 We ran into this in ibis, where we are indeed able to compile and successfully execute the ALL modifier, but as soon as [we turned on sqlglot errors](ibis-project/ibis#11772), we then started getting spurious sqlglot errors: https://github.com/ibis-project/ibis/actions/runs/19549750869/job/55977864377?pr=11772
1 parent fa5f99e commit 1502316

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

sqlglot/dialects/trino.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ def _parse_json_query(self) -> exp.JSONExtract:
6969
)
7070

7171
class Generator(Presto.Generator):
72+
EXCEPT_INTERSECT_SUPPORT_ALL_CLAUSE = True
7273
PROPERTIES_LOCATION = {
7374
**Presto.Generator.PROPERTIES_LOCATION,
7475
exp.LocationProperty: exp.Properties.Location.POST_WITH,

0 commit comments

Comments
 (0)