minor updates, tests

Author: fivetran-kwoodbeck

sqlglot/dialects/duckdb.py

@@ -48,14 +48,6 @@
 from sqlglot.tokens import TokenType
 from sqlglot.parser import binary_range_parser
 
-# Bitwise operations that return binary when given binary input
-BITWISE_BINARY_OPS = (
-    exp.BitwiseLeftShift,
-    exp.BitwiseRightShift,
-    exp.BitwiseAnd,
-    exp.BitwiseOr,
-    exp.BitwiseXor,
-)
 
 # Regex to detect time zones in timestamps of the form [+|-]TT[:tt]
 # The pattern matches timezone offsets that appear after the time portion

tests/dialects/test_snowflake.py

@@ -1687,11 +1687,6 @@ def test_snowflake(self):
         self.validate_identity("SELECT BIT_XOR(a, b)", "SELECT BITXOR(a, b)")
         self.validate_identity("SELECT BIT_XOR(a, b, 'LEFT')", "SELECT BITXOR(a, b, 'LEFT')")
 
-        self.validate_identity("SELECT BITSHIFTLEFT(a, 1)")
-        self.validate_identity("SELECT BIT_SHIFTLEFT(a, 1)", "SELECT BITSHIFTLEFT(a, 1)")
-        self.validate_identity("SELECT BITSHIFTRIGHT(a, 1)")
-        self.validate_identity("SELECT BIT_SHIFTRIGHT(a, 1)", "SELECT BITSHIFTRIGHT(a, 1)")
-
         # duckdb has an order of operations precedence issue with bitshift and bitwise operators
         self.validate_all(
             "SELECT BITOR(BITSHIFTLEFT(5, 16), BITSHIFTLEFT(3, 8))",
@@ -1705,10 +1700,6 @@ def test_snowflake(self):
             "SELECT BITSHIFTLEFT(255, 4)",
             write={"duckdb": "SELECT CAST(255 AS INT128) << 4"},
         )
-        self.validate_all(
-            "SELECT BITSHIFTLEFT(255, 4)",
-            write={"duckdb": "SELECT CAST(255 AS INT128) << 4"},
-        )
         self.validate_all(
             "SELECT BITSHIFTLEFT(CAST(255 AS BINARY), 4)",
             write={"duckdb": "SELECT CAST(CAST(CAST(255 AS BLOB) AS BIT) << 4 AS BLOB)"},
@@ -1717,12 +1708,14 @@ def test_snowflake(self):
             "SELECT BITSHIFTLEFT(X'FF', 4)",
             write={"duckdb": "SELECT CAST(255 AS INT128) << 4"},
         )
-
         self.validate_all(
-            "SELECT BITSHIFTRIGHT(1024, 4)",
-            write={"duckdb": "SELECT CAST(1024 AS INT128) >> 4"},
+            "SELECT BITSHIFTRIGHT(255, 4)",
+            write={"duckdb": "SELECT CAST(255 AS INT128) >> 4"},
+        )
+        self.validate_all(
+            "SELECT BITSHIFTRIGHT(CAST(255 AS BINARY), 4)",
+            write={"duckdb": "SELECT CAST(CAST(CAST(255 AS BLOB) AS BIT) >> 4 AS BLOB)"},
         )
-
         self.validate_all(
             "SELECT BITSHIFTRIGHT(X'FF', 4)",
             write={"duckdb": "SELECT CAST(255 AS INT128) >> 4"},