Skip to content

Commit 2b3824f

Browse files
authored
Fix(duckdb): revert timestamp/datetime -> timestampntz parsing temporarily (#4878)
1 parent ba4a55f commit 2b3824f

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

sqlglot/dialects/duckdb.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,6 @@ class Tokenizer(tokens.Tokenizer):
322322
"BPCHAR": TokenType.TEXT,
323323
"CHAR": TokenType.TEXT,
324324
"CHARACTER VARYING": TokenType.TEXT,
325-
"DATETIME": TokenType.TIMESTAMPNTZ,
326325
"DETACH": TokenType.DETACH,
327326
"EXCLUDE": TokenType.EXCEPT,
328327
"LOGICAL": TokenType.BOOLEAN,
@@ -332,7 +331,6 @@ class Tokenizer(tokens.Tokenizer):
332331
"SIGNED": TokenType.INT,
333332
"STRING": TokenType.TEXT,
334333
"SUMMARIZE": TokenType.SUMMARIZE,
335-
"TIMESTAMP": TokenType.TIMESTAMPNTZ,
336334
"TIMESTAMP_S": TokenType.TIMESTAMP_S,
337335
"TIMESTAMP_MS": TokenType.TIMESTAMP_MS,
338336
"TIMESTAMP_NS": TokenType.TIMESTAMP_NS,

tests/dialects/test_clickhouse.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ def test_clickhouse(self):
281281
self.validate_all(
282282
"SELECT CAST('2020-01-01' AS Nullable(DateTime)) + INTERVAL '500' MICROSECOND",
283283
read={
284+
"duckdb": "SELECT TIMESTAMP '2020-01-01' + INTERVAL '500 us'",
284285
"postgres": "SELECT TIMESTAMP '2020-01-01' + INTERVAL '500 us'",
285286
},
286287
write={

tests/dialects/test_duckdb.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,6 @@ def test_duckdb(self):
423423
"SELECT STRFTIME(CAST('2020-01-01' AS TIMESTAMP), CONCAT('%Y', '%m'))",
424424
write={
425425
"duckdb": "SELECT STRFTIME(CAST('2020-01-01' AS TIMESTAMP), CONCAT('%Y', '%m'))",
426-
"spark": "SELECT DATE_FORMAT(CAST('2020-01-01' AS TIMESTAMP_NTZ), CONCAT(COALESCE('yyyy', ''), COALESCE('MM', '')))",
427426
"tsql": "SELECT FORMAT(CAST('2020-01-01' AS DATETIME2), CONCAT('yyyy', 'MM'))",
428427
},
429428
)

tests/dialects/test_mysql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1311,7 +1311,7 @@ def test_safe_div(self):
13111311

13121312
def test_timestamp_trunc(self):
13131313
hive_dialects = ("spark", "databricks")
1314-
for dialect in ("postgres", "snowflake", *hive_dialects):
1314+
for dialect in ("postgres", "snowflake", "duckdb", *hive_dialects):
13151315
for unit in (
13161316
"SECOND",
13171317
"DAY",

0 commit comments

Comments
 (0)