first arg should use _parse_disjunction

Author: treysp

sqlglot/dialects/bigquery.py

@@ -919,16 +919,12 @@ def _parse_make_interval(self) -> exp.MakeInterval:
         def _parse_approx_quantiles(self) -> t.Optional[exp.Expression]:
             # APPROX_QUANTILES([DISTINCT] expression, number [{IGNORE | RESPECT} NULLS])
             distinct = self._match(TokenType.DISTINCT)
-            this = self._parse_assignment()
+            this = self._parse_disjunction()
             if distinct:
                 this = self.expression(exp.Distinct, expressions=[this])
 
-            if not self._match(TokenType.COMMA):
-                self.raise_error(
-                    "Expected comma between expression and number of quantiles in APPROX_QUANTILES"
-                )
-
-            expression = self._parse_assignment()
+            self._match(TokenType.COMMA)
+            expression = self._parse_disjunction()
             if not expression:
                 self.raise_error("Expected number of quantiles argument in APPROX_QUANTILES")
 

tests/dialects/test_bigquery.py

@@ -3448,6 +3448,8 @@ def test_round(self):
 
     def test_approx_quantiles(self):
         self.validate_identity("APPROX_QUANTILES(x, 2)")
+        self.validate_identity("APPROX_QUANTILES(FALSE OR TRUE, 2)")
+        self.validate_identity("APPROX_QUANTILES((SELECT 1 AS val), CAST(2.1 AS INT64))")
         self.validate_identity("APPROX_QUANTILES(DISTINCT x, 2)")
         self.validate_identity("APPROX_QUANTILES(x, 2 RESPECT NULLS)")
         self.validate_identity("APPROX_QUANTILES(x, 2 IGNORE NULLS)")