Skip to content

Commit 335d425

Browse files
minor test updates
1 parent 0a239cd commit 335d425

File tree

2 files changed

+9
-26
lines changed

2 files changed

+9
-26
lines changed

tests/dialects/test_snowflake.py

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1946,9 +1946,9 @@ def test_snowflake(self):
19461946
},
19471947
)
19481948
self.validate_all(
1949-
"SELECT DATE_PART(NANOSECOND, CAST('2026-01-06 11:45:00.123456789' AS TIMESTAMP))",
1949+
"SELECT DATE_PART(NANOSECOND, CAST('2026-01-06 11:45:00.123456789' AS TIMESTAMPNTZ))",
19501950
write={
1951-
"snowflake": "SELECT DATE_PART(NANOSECOND, CAST('2026-01-06 11:45:00.123456789' AS TIMESTAMP))",
1951+
"snowflake": "SELECT DATE_PART(NANOSECOND, CAST('2026-01-06 11:45:00.123456789' AS TIMESTAMPNTZ))",
19521952
"duckdb": "SELECT CAST(STRFTIME(CAST(CAST('2026-01-06 11:45:00.123456789' AS TIMESTAMP) AS TIMESTAMP_NS), '%n') AS BIGINT)",
19531953
},
19541954
)
@@ -2037,6 +2037,13 @@ def test_snowflake(self):
20372037
"duckdb": "SELECT CAST(STRFTIME(CAST('2026-01-06 11:45:00' AS TIMESTAMP), '%G') AS INT)",
20382038
},
20392039
)
2040+
self.validate_all(
2041+
"SELECT EXTRACT(HOUR FROM CAST('2026-01-06 11:45:00' AS TIMESTAMP_NTZ))",
2042+
write={
2043+
"snowflake": "SELECT DATE_PART(HOUR, CAST('2026-01-06 11:45:00' AS TIMESTAMPNTZ))",
2044+
"duckdb": "SELECT EXTRACT(HOUR FROM CAST('2026-01-06 11:45:00' AS TIMESTAMP))",
2045+
},
2046+
)
20402047
self.validate_all(
20412048
"SELECT EXTRACT(MINUTE FROM CAST('2026-01-06 11:45:00' AS TIMESTAMP_NTZ))",
20422049
write={
@@ -2171,13 +2178,6 @@ def test_snowflake(self):
21712178
"duckdb": "SELECT CAST(STRFTIME(CAST('2026-01-06' AS DATE), '%G') AS INT)",
21722179
},
21732180
)
2174-
self.validate_all(
2175-
"SELECT EXTRACT(EPOCH_SECOND FROM CAST('2026-01-06' AS DATE))",
2176-
write={
2177-
"snowflake": "SELECT DATE_PART(EPOCH_SECOND, CAST('2026-01-06' AS DATE))",
2178-
"duckdb": "SELECT CAST(EPOCH(CAST('2026-01-06' AS DATE)) AS BIGINT)",
2179-
},
2180-
)
21812181
self.validate_all(
21822182
"SELECT EXTRACT(HOUR FROM CAST('11:45:00.123456789' AS TIME))",
21832183
write={
@@ -2387,19 +2387,6 @@ def test_snowflake(self):
23872387
},
23882388
)
23892389

2390-
# EXTRACT - converts to DATE_PART in Snowflake
2391-
self.validate_identity(
2392-
"SELECT EXTRACT(YEAR FROM CAST('2024-05-09' AS DATE))",
2393-
"SELECT DATE_PART(YEAR, CAST('2024-05-09' AS DATE))",
2394-
)
2395-
self.validate_identity(
2396-
"SELECT EXTRACT(MONTH FROM CAST('2024-05-09 08:50:57' AS TIMESTAMP))",
2397-
"SELECT DATE_PART(MONTH, CAST('2024-05-09 08:50:57' AS TIMESTAMP))",
2398-
)
2399-
self.validate_identity(
2400-
"SELECT EXTRACT(MINUTE, CAST('08:50:57' AS TIME))",
2401-
"SELECT DATE_PART(MINUTE, CAST('08:50:57' AS TIME))",
2402-
)
24032390
self.validate_identity("SELECT HOUR(CAST('08:50:57' AS TIME))")
24042391
self.validate_identity("SELECT MINUTE(CAST('08:50:57' AS TIME))")
24052392
self.validate_identity("SELECT SECOND(CAST('08:50:57' AS TIME))")

tests/fixtures/optimizer/annotate_functions.sql

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2871,10 +2871,6 @@ INT;
28712871
EXTRACT(YEAROFWEEKISO FROM CAST('2026-01-06' AS DATE));
28722872
INT;
28732873

2874-
# dialect: snowflake
2875-
EXTRACT(EPOCH_SECOND FROM CAST('2026-01-06' AS DATE));
2876-
BIGINT;
2877-
28782874
# dialect: snowflake
28792875
EXTRACT(HOUR FROM CAST('11:45:00.123456789' AS TIME));
28802876
INT;

0 commit comments

Comments
 (0)