feat: add tokens to functions

Author: tobymao

sqlglot/parser.py

@@ -6076,7 +6076,8 @@ def _parse_function_call(
                     this = exp.Identifier(this=this, quoted=True).update_positions(token)
 
                 this = self.expression(exp.Anonymous, this=this, expressions=args)
-                this = this.update_positions(token)
+
+            this = this.update_positions(token)
 
         if isinstance(this, exp.Expression):
             this.add_comments(comments)

tests/dialects/test_clickhouse.py

@@ -32,7 +32,6 @@ def test_clickhouse(self):
 
         expr = parse_one("count(x)")
         self.assertEqual(expr.sql(dialect="clickhouse"), "COUNT(x)")
-        self.assertIsNone(expr._meta)
 
         self.validate_identity('SELECT DISTINCT ON ("id") * FROM t')
         self.validate_identity("SELECT 1 OR (1 = 2)")

tests/test_parser.py

@@ -990,6 +990,8 @@ def test_token_position_meta(self):
         ast = parse_one("SELECT 1")
         self.assertEqual(ast.find(exp.Literal).meta, {"line": 1, "col": 8, "start": 7, "end": 7})
 
+        self.assertEqual(parse_one("max(1)").meta, {"col": 3, "end": 2, "line": 1, "start": 0})
+
     def test_quoted_identifier_meta(self):
         sql = 'SELECT "a" FROM "test_schema"."test_table_a"'
         ast = parse_one(sql)