feat(duckdb)!: transpile bigquery's %x format literal (#6375)

* feat(snowflake)!: %x is treated a literal in duckdb. support %x  locale-dependent formats.

* feat(snowflake)!: %x is treated a literal in duckdb. support %x  locale-dependent formats.

* Revert "feat(snowflake)!: %x is treated a literal in duckdb. support %x  locale-dependent formats."

This reverts commit 4514a5c.

* Revert "feat(snowflake)!: %x is treated a literal in duckdb. support %x  locale-dependent formats."

This reverts commit a2400e8.

* feat(snowflake)!: transpilation support for %x formatting - format_date -bq to duckdb

* feat(snowflake)!: transpilation support for %x formatting - format_date -bq to duckdb

* feat(snowflake)!: transpilation support for %x formatting - format_date -bq to duckdb

* feat(snowflake)!: transpilation support for %x formatting - format_date -bq to duckdb

* feat(snowflake)!: transpilation support for %x formatting - format_date -bq to duckdb

* feat(snowflake)!: transpilation support for %x formatting - format_date -bq to duckdb

Author: fivetran-ashashankar

sqlglot/dialects/bigquery.py

@@ -310,11 +310,11 @@ def _build_levenshtein(args: t.List) -> exp.Levenshtein:
 
 def _build_format_time(expr_type: t.Type[exp.Expression]) -> t.Callable[[t.List], exp.TimeToStr]:
     def _builder(args: t.List) -> exp.TimeToStr:
-        return exp.TimeToStr(
-            this=expr_type(this=seq_get(args, 1)),
-            format=seq_get(args, 0),
-            zone=seq_get(args, 2),
+        formatted_time = build_formatted_time(exp.TimeToStr, "bigquery")(
+            [expr_type(this=seq_get(args, 1)), seq_get(args, 0)]
         )
+        formatted_time.set("zone", seq_get(args, 2))
+        return formatted_time
 
     return _builder
 
@@ -377,6 +377,7 @@ class BigQuery(Dialect):
 
     # https://cloud.google.com/bigquery/docs/reference/standard-sql/format-elements#format_elements_date_time
     TIME_MAPPING = {
+        "%x": "%m/%d/%y",
         "%D": "%m/%d/%y",
         "%E6S": "%S.%f",
         "%e": "%-d",

sqlglot/dialects/duckdb.py

@@ -423,6 +423,7 @@ class DuckDB(Dialect):
         **Dialect.DATE_PART_MAPPING,
         "DAYOFWEEKISO": "ISODOW",
     }
+
     DATE_PART_MAPPING.pop("WEEKDAY")
 
     def to_json_path(self, path: t.Optional[exp.Expression]) -> t.Optional[exp.Expression]:

tests/dialects/test_bigquery.py

@@ -2897,8 +2897,8 @@ def test_format_temporal(self):
         self.validate_all(
             "SELECT FORMAT_DATETIME('%x', '2023-12-25 15:30:00')",
             write={
-                "bigquery": "SELECT FORMAT_DATETIME('%x', '2023-12-25 15:30:00')",
-                "duckdb": "SELECT STRFTIME(CAST('2023-12-25 15:30:00' AS TIMESTAMP), '%x')",
+                "bigquery": "SELECT FORMAT_DATETIME('%D', '2023-12-25 15:30:00')",
+                "duckdb": "SELECT STRFTIME(CAST('2023-12-25 15:30:00' AS TIMESTAMP), '%m/%d/%y')",
             },
         )
         self.validate_all(