Skip to content

Commit 3ec9a98

Browse files
committed
undo the _sql position
1 parent d0a6cfa commit 3ec9a98

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

sqlglot/dialects/mysql.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -756,20 +756,13 @@ class Generator(generator.Generator):
756756
VARCHAR_REQUIRES_SIZE = True
757757
SUPPORTS_MEDIAN = False
758758

759-
def chr_sql(self, expression: exp.Chr) -> str:
760-
this = self.expressions(sqls=[expression.this] + expression.expressions)
761-
charset = expression.args.get("charset")
762-
using = f" USING {self.sql(charset)}" if charset else ""
763-
return f"CHAR({this}{using})"
764-
765759
TRANSFORMS = {
766760
**generator.Generator.TRANSFORMS,
767761
exp.ArrayAgg: rename_func("GROUP_CONCAT"),
768762
exp.BitwiseAndAgg: rename_func("BIT_AND"),
769763
exp.BitwiseOrAgg: rename_func("BIT_OR"),
770764
exp.BitwiseXorAgg: rename_func("BIT_XOR"),
771765
exp.BitwiseCount: rename_func("BIT_COUNT"),
772-
exp.Chr: chr_sql,
773766
exp.CurrentDate: no_paren_current_date_sql,
774767
exp.DateDiff: _remove_ts_or_ds_to_date(
775768
lambda self, e: self.func("DATEDIFF", e.this, e.expression), ("this", "expression")
@@ -1311,6 +1304,12 @@ def _oldstyle_limit_sql(self, expression: exp.Show) -> str:
13111304
return f" LIMIT {limit_offset}"
13121305
return ""
13131306

1307+
def chr_sql(self, expression: exp.Chr) -> str:
1308+
this = self.expressions(sqls=[expression.this] + expression.expressions)
1309+
charset = expression.args.get("charset")
1310+
using = f" USING {self.sql(charset)}" if charset else ""
1311+
return f"CHAR({this}{using})"
1312+
13141313
def timestamptrunc_sql(self, expression: exp.TimestampTrunc) -> str:
13151314
unit = expression.args.get("unit")
13161315

sqlglot/dialects/singlestore.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,6 @@ def _unicode_substitute(m: re.Match[str]) -> str:
346346

347347
TRANSFORMS = {
348348
**MySQL.Generator.TRANSFORMS,
349-
# exp.Chr set below to ensure override
350349
exp.TsOrDsToDate: lambda self, e: self.func("TO_DATE", e.this, self.format_time(e))
351350
if e.args.get("format")
352351
else self.func("DATE", e.this),

0 commit comments

Comments
 (0)