fix: qualify using (#4646)

Author: tobymao

sqlglot/optimizer/qualify_columns.py

@@ -173,6 +173,9 @@ def _update_source_columns(source_name: str) -> None:
     names = {join.alias_or_name for join in joins}
     ordered = [key for key in scope.selected_sources if key not in names]
 
+    if names and not ordered:
+        raise OptimizeError(f"Joins {names} missing source table {scope.expression}")
+
     # Mapping of automatically joined column names to an ordered set of source names (dict).
     column_tables: t.Dict[str, t.Dict[str, t.Any]] = {}
 

tests/fixtures/optimizer/qualify_columns.sql

@@ -831,4 +831,4 @@ SELECT x.a AS a, COALESCE(x.b, y_2.b) AS b, y_2.c AS c FROM x AS x SEMI JOIN y A
 
 # title: ANTI + normal joins reinclude the table on scope
 SELECT * FROM x ANTI JOIN y USING (b) JOIN y USING (b);
-SELECT x.a AS a, COALESCE(x.b, y_2.b) AS b, y_2.c AS c FROM x AS x ANTI JOIN y AS y ON x.b = y.b JOIN y AS y_2 ON x.b = y_2.b;
+SELECT x.a AS a, COALESCE(x.b, y_2.b) AS b, y_2.c AS c FROM x AS x ANTI JOIN y AS y ON x.b = y.b JOIN y AS y_2 ON x.b = y_2.b;

tests/fixtures/optimizer/qualify_columns__invalid.sql

@@ -12,3 +12,4 @@ SELECT a, SUM(b) FROM x GROUP BY 3;
 SELECT p FROM (SELECT x from xx) y CROSS JOIN yy CROSS JOIN zz
 SELECT a FROM (SELECT * FROM x CROSS JOIN y);
 SELECT x FROM tbl AS tbl(a);
+SELECT a JOIN b USING (a);