Fixups

Author: georgesittas

sqlglot/dialects/duckdb.py

@@ -1187,12 +1187,12 @@ class Generator(generator.Generator):
             exp.DayOfYear: rename_func("DAYOFYEAR"),
             exp.Dayname: lambda self, e: (
                 self.func("STRFTIME", e.this, exp.Literal.string("%a"))
-                if e.args.get("name_format")
+                if e.args.get("abbreviated")
                 else self.func("DAYNAME", e.this)
             ),
             exp.Monthname: lambda self, e: (
                 self.func("STRFTIME", e.this, exp.Literal.string("%b"))
-                if e.args.get("name_format")
+                if e.args.get("abbreviated")
                 else self.func("MONTHNAME", e.this)
             ),
             exp.DataType: _datatype_sql,

sqlglot/dialects/snowflake.py

@@ -750,7 +750,7 @@ class Parser(parser.Parser):
             "DATE_TRUNC": _date_trunc_to_time,
             "DATEADD": _build_date_time_add(exp.DateAdd),
             "DATEDIFF": _build_datediff,
-            "DAYNAME": lambda args: exp.Dayname(this=seq_get(args, 0), name_format=True),
+            "DAYNAME": lambda args: exp.Dayname(this=seq_get(args, 0), abbreviated=True),
             "DAYOFWEEKISO": exp.DayOfWeekIso.from_arg_list,
             "DIV0": _build_if_from_div0,
             "DIV0NULL": _build_if_from_div0null,
@@ -777,7 +777,7 @@ class Parser(parser.Parser):
             "MD5_BINARY": exp.MD5Digest.from_arg_list,
             "MD5_NUMBER_LOWER64": exp.MD5NumberLower64.from_arg_list,
             "MD5_NUMBER_UPPER64": exp.MD5NumberUpper64.from_arg_list,
-            "MONTHNAME": lambda args: exp.Monthname(this=seq_get(args, 0), name_format=True),
+            "MONTHNAME": lambda args: exp.Monthname(this=seq_get(args, 0), abbreviated=True),
             "LAST_DAY": lambda args: exp.LastDay(
                 this=seq_get(args, 0), unit=map_date_part(seq_get(args, 1))
             ),

sqlglot/expressions.py

@@ -6564,7 +6564,7 @@ class DayOfYear(Func):
 
 
 class Dayname(Func):
-    arg_types = {"this": True, "name_format": False}
+    arg_types = {"this": True, "abbreviated": False}
 
 
 class ToDays(Func):
@@ -7518,7 +7518,7 @@ class Month(Func):
 
 
 class Monthname(Func):
-    arg_types = {"this": True, "name_format": False}
+    arg_types = {"this": True, "abbreviated": False}
 
 
 class AddMonths(Func):

tests/dialects/test_duckdb.py

@@ -369,6 +369,8 @@ def test_duckdb(self):
             parse_one("a // b", read="duckdb").assert_is(exp.IntDiv).sql(dialect="duckdb"), "a // b"
         )
 
+        self.validate_identity("DAYNAME(x)")
+        self.validate_identity("MONTHNAME(x)")
         self.validate_identity(
             "SELECT LIST_TRANSFORM([5, NULL, 6], (x, y) -> COALESCE(x, y, 0) + 1)"
         )