Skip to content

Commit b00d857

Browse files
authored
feat: add support for specifying column in row_number function (#4406)
1 parent de157ab commit b00d857

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

sqlglot/expressions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6329,7 +6329,7 @@ class Round(Func):
63296329

63306330

63316331
class RowNumber(Func):
6332-
arg_types: t.Dict[str, t.Any] = {}
6332+
arg_types = {"this": False}
63336333

63346334

63356335
class SafeDivide(Func):

tests/dialects/test_clickhouse.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,3 +1245,11 @@ def test_traverse_scope(self):
12451245
scopes = traverse_scope(parse_one(sql, dialect=self.dialect))
12461246
self.assertEqual(len(scopes), 1)
12471247
self.assertEqual(set(scopes[0].sources), {"t"})
1248+
1249+
def test_window_functions(self):
1250+
self.validate_identity(
1251+
"SELECT row_number(column1) OVER (PARTITION BY column2 ORDER BY column3) FROM table"
1252+
)
1253+
self.validate_identity(
1254+
"SELECT row_number() OVER (PARTITION BY column2 ORDER BY column3) FROM table"
1255+
)

0 commit comments

Comments
 (0)