partial fix of binary issues

Author: fivetran-kwoodbeck

sqlglot/dialects/duckdb.py

@@ -771,9 +771,9 @@ def _bitshift_sql(
         this = annotate_types(this, dialect=self.dialect)
 
     # Deal with binary separately, remember the original type, cast back later
-    if _is_binary(this):
+    if _is_binary(this) or isinstance(this, exp.HexString):
         original_type = this.to if isinstance(this, exp.Cast) else exp.DataType.build("BLOB")
-        expression.set("this", _cast_to_bit(this))
+        expression.set("this", exp.cast(this, exp.DataType.Type.BIT))
     elif expression.args.get("requires_int128"):
         this.replace(exp.cast(this, exp.DataType.Type.INT128))
 

sqlglot/dialects/snowflake.py

@@ -168,9 +168,6 @@ def _builder(args: t.List) -> B | exp.Anonymous:
         # Snowflake specifies INT128 for bitwise shifts
         if expr_type in (exp.BitwiseLeftShift, exp.BitwiseRightShift):
             result.set("requires_int128", True)
-            # Mark HexStrings as integers for proper rendering in target dialects
-            for hexstr in result.find_all(exp.HexString):
-                hexstr.set("is_integer", True)
 
         return result
 

tests/dialects/test_snowflake.py

@@ -1721,8 +1721,8 @@ def test_snowflake(self):
         self.validate_all(
             "SELECT BITSHIFTLEFT(X'FF', 4)",
             write={
-                "snowflake": "SELECT BITSHIFTLEFT(255, 4)",
-                "duckdb": "SELECT CAST(255 AS INT128) << 4",
+                "snowflake": "SELECT BITSHIFTLEFT(x'FF', 4)",
+                "duckdb": "SELECT CAST(CAST(UNHEX('FF') AS BIT) << 4 AS BLOB)",
             },
         )
         self.validate_all(
@@ -1735,8 +1735,22 @@ def test_snowflake(self):
         self.validate_all(
             "SELECT BITSHIFTRIGHT(X'FF', 4)",
             write={
-                "snowflake": "SELECT BITSHIFTRIGHT(255, 4)",
-                "duckdb": "SELECT CAST(255 AS INT128) >> 4",
+                "snowflake": "SELECT BITSHIFTRIGHT(x'FF', 4)",
+                "duckdb": "SELECT CAST(CAST(UNHEX('FF') AS BIT) >> 4 AS BLOB)",
+            },
+        )
+        self.validate_all(
+            "SELECT BITSHIFTLEFT(X'002A'::BINARY, 1)",
+            write={
+                "snowflake": "SELECT BITSHIFTLEFT(CAST(x'002A' AS BINARY), 1)",
+                "duckdb": "SELECT CAST(CAST(UNHEX('002A') AS BIT) << 1 AS BLOB)",
+            },
+        )
+        self.validate_all(
+            "SELECT BITSHIFTRIGHT(X'002A'::BINARY, 1)",
+            write={
+                "snowflake": "SELECT BITSHIFTRIGHT(CAST(x'002A' AS BINARY), 1)",
+                "duckdb": "SELECT CAST(CAST(UNHEX('002A') AS BIT) >> 1 AS BLOB)",
             },
         )