Add DETACH as command to DuckDB dialect (#4405)

naoyak · web-flow · commit eb1b52a8d5d2 · 2024-11-15T15:36:14.000-08:00
diff --git a/sqlglot/dialects/duckdb.py b/sqlglot/dialects/duckdb.py
@@ -316,6 +316,7 @@ class Tokenizer(tokens.Tokenizer):
             "BPCHAR": TokenType.TEXT,
             "CHAR": TokenType.TEXT,
             "CHARACTER VARYING": TokenType.TEXT,
+            "DETACH": TokenType.COMMAND,
             "EXCLUDE": TokenType.EXCEPT,
             "LOGICAL": TokenType.BOOLEAN,
             "ONLY": TokenType.ONLY,
diff --git a/tests/dialects/test_duckdb.py b/tests/dialects/test_duckdb.py
@@ -382,6 +382,7 @@ def test_duckdb(self):
         self.validate_identity(
             "ATTACH DATABASE ':memory:' AS new_database", check_command_warning=True
         )
+        self.validate_identity("DETACH DATABASE new_database", check_command_warning=True)
         self.validate_identity(
             "SELECT {'yes': 'duck', 'maybe': 'goose', 'huh': NULL, 'no': 'heron'}"
         )

Original file line number	Diff line number	Diff line change
`@@ -382,6 +382,7 @@ def test_duckdb(self):`
`382`	`382`	`self.validate_identity(`
`383`	`383`	`"ATTACH DATABASE ':memory:' AS new_database", check_command_warning=True`
`384`	`384`	`)`
	`385`	`+ self.validate_identity("DETACH DATABASE new_database", check_command_warning=True)`
`385`	`386`	`self.validate_identity(`
`386`	`387`	`"SELECT {'yes': 'duck', 'maybe': 'goose', 'huh': NULL, 'no': 'heron'}"`
`387`	`388`	`)`