-
Notifications
You must be signed in to change notification settings - Fork 1k
Feat: transpile BQ APPROX_QUANTILES to DuckDB #6349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b25bcd4 to
726e0df
Compare
a84c84c to
69a5fa6
Compare
georgesittas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only thing I'd like to understand a bit more is what the results look like in source/target. Do they mostly match, with the only difference being how the estimation happens? Types and all included?
69a5fa6 to
a735c18
Compare
a735c18 to
1aa03ab
Compare
Yep, good match other than algorithm
|
|
Great, thanks! |
georgesittas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Notes:
RESPECT NULLSoption