fix(duckdb): Make exp.DateFromParts more lenient
#6397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6394
Although this is not properly documented, the following query is valid in DuckDB:
This is because:
DATE_PARTreturns either anINT64or aSTRUCTof values, depending on the input expression:MAKE_DATEaccepts either INT64s or aSTRUCTwhich encodes those kwargsNote: To properly represent that in the AST we'd have to infer whether the
MAKE_DATEexpression evaluates to anINT64or aSTRUCT, but since this low ROI we instead store that in the first argumentyear.Docs
DuckDB MAKE_DATE | DuckDB DATE_PART