-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(snowflake)!: annotate types for MAP_* functions #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 2170 total, 1597 passed (pass rate: 73.6%), sqlglot version: sqlglot:feature/annotatetype-map_functions: 2170 total, 1599 passed (pass rate: 73.7%), sqlglot version: Difference: ⬆ improved by |
geooo109
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also check if other databases support these functions ?
@georgesittas yes, here is what matched the searches: |
b797fca to
9dbdecd
Compare
* Annotation for Map functions * updated tests * updates to parameters and tests * Rename `expressions` -> `expression` * Rename `key` -> `expressions` --------- Co-authored-by: Jo <[email protected]>
Documentation:
https://docs.snowflake.com/en/sql-reference/functions/map_cat
https://docs.snowflake.com/en/sql-reference/functions/map_contains_key
https://docs.snowflake.com/en/sql-reference/functions/map_delete
https://docs.snowflake.com/en/sql-reference/functions/map_insert
https://docs.snowflake.com/en/sql-reference/functions/map_keys
https://docs.snowflake.com/en/sql-reference/functions/map_pick
https://docs.snowflake.com/en/sql-reference/functions/map_size