Skip to content

Conversation

@fivetran-kwoodbeck fivetran-kwoodbeck changed the title feat(snowflake)!: annotate type for MAP* functions feat(snowflake)!: annotate type for MAP_* functions Dec 18, 2025
@fivetran-kwoodbeck fivetran-kwoodbeck changed the title feat(snowflake)!: annotate type for MAP_* functions feat(snowflake)!: annotate types for MAP_* functions Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

SQLGlot Integration Test Results

Comparing:

  • this branch (sqlglot:feature/annotatetype-map_functions, sqlglot version: feature/annotatetype-map_functions)
  • baseline (main, sqlglot version: 28.5.1.dev15)

⚠️ Limited to dialects: snowflake

By Dialect

dialect main sqlglot:feature/annotatetype-map_functions difference links
snowflake -> duckdb 622/1085 passed (57.3%) 624/1085 passed (57.5%) ⬆ improved by 0.2% full result / delta
snowflake -> snowflake 975/1085 passed (89.9%) 975/1085 passed (89.9%) No change full result / delta

Overall

main: 2170 total, 1597 passed (pass rate: 73.6%), sqlglot version: 28.5.1.dev15

sqlglot:feature/annotatetype-map_functions: 2170 total, 1599 passed (pass rate: 73.7%), sqlglot version: feature/annotatetype-map_functions

Difference: ⬆ improved by 0.1%

Copy link
Collaborator

@geooo109 geooo109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also check if other databases support these functions ?

@fivetran-kwoodbeck
Copy link
Collaborator Author

Did you also check if other databases support these functions ?

@georgesittas yes, here is what matched the searches:

MAP_CAT: snowflake only
MAP_CONTAINS_KEY:
spark	https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.map_keys.html
MAP_DELETE: snowflake only
MAP_INSERT: snowflake only
MAP_PICK:	snowflake only
MAP_KEYS:
hive	https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF
presto	https://prestodb.io/docs/current/functions/map.html
spark	https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.map_keys.html
trino	https://trino.io/docs/current/functions/map.html
databricks	https://docs.databricks.com/aws/en/sql/language-manual/functions/map_keys
MAP_SIZE:	snowflake only

@fivetran-kwoodbeck fivetran-kwoodbeck force-pushed the feature/annotatetype-map_functions branch from b797fca to 9dbdecd Compare December 19, 2025 15:44
@georgesittas georgesittas merged commit 77ff9d0 into main Dec 19, 2025
8 checks passed
@georgesittas georgesittas deleted the feature/annotatetype-map_functions branch December 19, 2025 16:09
fivetran-kwoodbeck added a commit that referenced this pull request Dec 19, 2025
* Annotation for Map functions

* updated tests

* updates to parameters and tests

* Rename `expressions` -> `expression`

* Rename `key` -> `expressions`

---------

Co-authored-by: Jo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants