fix(oracle)!: USING keyword in chr #6637
Merged
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhishekASLK
changed the title
VaggelisD
reviewed
Dec 29, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Hey @AbhishekASLK, looks like MySQL also supports this function and SQLGlot already has support for it.
Check out mysql.py for how exp.Chr is handled in FUNCTION_PARSERS and chr_sql, we can probably move both of these to the base dialect to solve Oracle too.
Contributor
Author
Sure, will look into this shortly. |
AbhishekASLK
commented
Dec 29, 2025
VaggelisD
reviewed
Dec 29, 2025
VaggelisD
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parsing error for
USINGkeyword inoracledialectSQL:
Documentation