Add current app-version

env variable

Author: toderian

.github/workflows/pr-build.yml

@@ -4,47 +4,45 @@ on:
   pull_request:
     branches: ["main"]
 
-env:
-  APP_VERSION: ""  # Define a default value for global accessibility
-
 jobs:
   check-version:
     runs-on: ubuntu-latest
     outputs:
+      app-version: ${{ steps.check-version.outputs.app-version }}
       should-run: ${{ steps.check-version.outputs.should-run }}
 
     steps:
       - uses: actions/checkout@v3
         with:
-          fetch-depth: 0 # Fetches all history for all branches and tags
+          fetch-depth: 0
 
       - name: Get latest release version
         id: latest-version
         run: |
           LATEST_TAG=$(git describe --tags `git rev-list --tags --max-count=1`)
           echo "Latest tag is $LATEST_TAG"
-          echo "LATEST_TAG=$LATEST_TAG" >> $GITHUB_ENV
+          echo "::set-output name=latest-tag::$LATEST_TAG"
 
       - name: Check version in ver.py
         id: check-version
         run: |
           CURRENT_VERSION=$(cat ver.py | grep -o "'.*'" | tr -d "'")
           echo "Current version is $CURRENT_VERSION"
 
-          if [ "$CURRENT_VERSION" == "$LATEST_TAG" ]; then
+          if [ "$CURRENT_VERSION" == "${{ steps.latest-version.outputs.latest-tag }}" ]; then
             echo "Version $CURRENT_VERSION has not been incremented vs already released $LATEST_TAG. Build will be cancelled."
             echo "::set-output name=should-run::false"
             exit 1
           else
             echo "Current version $CURRENT_VERSION differs from latest tag $LATEST_TAG. Build will continue."
             echo "::set-output name=should-run::true"
-            echo "APP_VERSION=$CURRENT_VERSION" >> $GITHUB_ENV
+            echo "::set-output name=app-version::$CURRENT_VERSION"
           fi
 
   build:
     needs: check-version
     if: needs.check-version.outputs.should-run == 'true'
-
+    runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         include:
@@ -60,24 +58,6 @@ jobs:
             name: EdgeNodeLauncher-LINUX_Ubuntu-24.04
             platformDependencies: sudo apt-get update && sudo apt install -y '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev --fix-missing
 
-          - os: ubuntu-22.04
-            build: |
-              chmod +x build_scripts/unix_build.sh
-              ./build_scripts/unix_build.sh
-            name: EdgeNodeLauncher-LINUX_Ubuntu-22.04
-            platformDependencies: sudo apt-get update && sudo apt install -y '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev --fix-missing
-
-          - os: ubuntu-20.04
-            build: |
-              chmod +x build_scripts/unix_build.sh
-              ./build_scripts/unix_build.sh
-            name: EdgeNodeLauncher-LINUX_Ubuntu-20.04
-            platformDependencies: sudo apt-get update && sudo apt-get install -y '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev --fix-missing
-
-    name: Build installers ${{ matrix.os }}
-    runs-on: ${{ matrix.os }}
-    permissions: write-all
-
     steps:
       - uses: actions/checkout@v3
       - name: Set up Python 3.10.11
@@ -90,14 +70,6 @@ jobs:
           pip install -r requirements.txt
           pip3 install --upgrade PyInstaller pyinstaller-hooks-contrib
 
-      - name: Replace placeholder in const.py (Windows)
-        if: runner.os == 'Windows'
-        env:
-          MQTT_K: ${{ secrets.MQTT_K }}
-        run: |
-          $filePath = "utils/const.py"
-          (Get-Content $filePath) -replace '\*\*\*\*\*\*\*\*\*\*\*\*\*\*\*\*', "${{ env.MQTT_K }}" | Set-Content $filePath
-
       - name: Replace placeholder in const.py (Linux)
         if: runner.os == 'Linux'
         env:
@@ -111,35 +83,21 @@ jobs:
       - name: Save build artifacts
         uses: actions/upload-artifact@v3
         with:
-          name: ${{ matrix.name }}-build-${{ env.APP_VERSION }}-${{ github.event.pull_request.number }}-${{ github.sha }}
+          name: ${{ matrix.name }}-build-${{ needs.check-version.outputs.app-version }}-${{ github.event.pull_request.number }}-${{ github.sha }}
           path: dist/*
 
   collect-artifacts:
     needs: build
     runs-on: ubuntu-latest
-    permissions: write-all
-
     steps:
-      - name: Download build artifacts
+      - name: Download build artifacts (WIN32)
         uses: actions/download-artifact@v3
         with:
-          name: EdgeNodeLauncher-${{ env.APP_VERSION }}-WIN32-build-${{ github.event.pull_request.number }}-${{ github.sha }}
+          name: EdgeNodeLauncher-WIN32-build-${{ needs.check-version.outputs.app-version }}-${{ github.event.pull_request.number }}-${{ github.sha }}
           path: ./all-builds/EdgeNodeLauncher-WIN32
 
-      - name: Download build artifacts
+      - name: Download build artifacts (Ubuntu 24.04)
         uses: actions/download-artifact@v3
         with:
-          name: EdgeNodeLauncher-${{ env.APP_VERSION }}-LINUX_Ubuntu-24.04-build-${{ github.event.pull_request.number }}-${{ github.sha }}
+          name: EdgeNodeLauncher-LINUX_Ubuntu-24.04-build-${{ needs.check-version.outputs.app-version }}-${{ github.event.pull_request.number }}-${{ github.sha }}
           path: ./all-builds/EdgeNodeLauncher-LINUX_Ubuntu-24.04
-
-      - name: Download build artifacts
-        uses: actions/download-artifact@v3
-        with:
-          name: EdgeNodeLauncher-${{ env.APP_VERSION }}-LINUX_Ubuntu-22.04-build-${{ github.event.pull_request.number }}-${{ github.sha }}
-          path: ./all-builds/EdgeNodeLauncher-LINUX_Ubuntu-22.04
-
-      - name: Download build artifacts
-        uses: actions/download-artifact@v3
-        with:
-          name: EdgeNodeLauncher-${{ env.APP_VERSION }}-LINUX_Ubuntu-20.04-build-${{ github.event.pull_request.number }}-${{ github.sha }}
-          path: ./all-builds/EdgeNodeLauncher-LINUX_Ubuntu-20.04