fix: flaky test case with raw enter press (#730)

Author: doodlewind

tests/clipboard.spec.ts

@@ -2,7 +2,7 @@ import './utils/declare-test-window.js';
 import { test } from '@playwright/test';
 import {
   SHORT_KEY,
-  backsapce,
+  pressBackspace,
   copyByKeyboard,
   dragBetweenCoords,
   enterPlaygroundRoom,
@@ -18,6 +18,7 @@ import {
   setQuillSelection,
   setSelection,
   undoByClick,
+  pressSpace,
 } from './utils/actions/index.js';
 import {
   assertBlockTypes,
@@ -316,7 +317,7 @@ test('should keep first line format when pasted into a new line', async ({
   await initEmptyParagraphState(page);
   await focusRichText(page);
   await page.keyboard.type('-');
-  await page.keyboard.press('Space', { delay: 50 });
+  await pressSpace(page);
   await page.keyboard.type('1');
   await pressEnter(page);
   await pressTab(page);
@@ -364,7 +365,7 @@ test('should keep first line format when pasted into a new line', async ({
 
   await focusRichText(page, 3);
   await pressEnter(page);
-  await backsapce(page);
+  await pressBackspace(page);
   await pasteByKeyboard(page);
 
   await assertStoreMatchJSX(

tests/code.spec.ts

@@ -288,8 +288,8 @@ test('press enter twice at end of code block can jump out', async ({
   await initEmptyCodeBlockState(page);
   await focusRichText(page);
 
-  await page.keyboard.press('Enter');
-  await page.keyboard.press('Enter');
+  await pressEnter(page);
+  await pressEnter(page);
 
   const locator = page.locator('affine-paragraph');
   await expect(locator).toBeVisible();
@@ -302,7 +302,7 @@ test('press ArrowDown before code block can select code block', async ({
   await initEmptyParagraphState(page);
   await focusRichText(page);
 
-  await page.keyboard.press('Enter');
+  await pressEnter(page);
   await addCodeBlock(page);
   await page.keyboard.press('ArrowUp');
   await page.keyboard.press('ArrowDown');
@@ -318,8 +318,8 @@ test('press backspace after code block can select code block', async ({
   await initEmptyCodeBlockState(page);
   await focusRichText(page);
 
-  await page.keyboard.press('Enter');
-  await page.keyboard.press('Enter');
+  await pressEnter(page);
+  await pressEnter(page);
   await page.keyboard.press('Backspace');
 
   const locator = page.locator('.affine-page-selected-rects-container');
@@ -333,8 +333,8 @@ test('press ArrowUp after code block can select code block', async ({
   await initEmptyCodeBlockState(page);
   await focusRichText(page);
 
-  await page.keyboard.press('Enter');
-  await page.keyboard.press('Enter');
+  await pressEnter(page);
+  await pressEnter(page);
   await page.keyboard.press('ArrowUp');
 
   const locator = page.locator('.affine-page-selected-rects-container');

tests/list.spec.ts

@@ -21,6 +21,7 @@ import {
   pressTab,
   initEmptyParagraphState,
   clickBlockTypeMenuItem,
+  pressSpace,
 } from './utils/actions/index.js';
 
 test('add new bulleted list', async ({ page }) => {
@@ -291,8 +292,10 @@ test('should indent todo block preserve todo status', async ({ page }) => {
   await focusRichText(page);
   await page.keyboard.type('text1');
   await pressEnter(page);
-  await page.keyboard.type('[x] ');
-  await page.waitForTimeout(10);
+
+  await page.keyboard.type('[x]');
+  await pressSpace(page);
+
   await page.keyboard.type('todo item');
   await pressTab(page);
   await assertStoreMatchJSX(

tests/selection.spec.ts

@@ -587,7 +587,8 @@ test('Delete the blank line between two dividers', async ({ page }) => {
   await focusRichText(page);
   await page.keyboard.type('--- ');
   await assertDivider(page, 1);
-  await page.keyboard.press('Enter');
+
+  await pressEnter(page);
   await page.keyboard.type('--- ');
   await page.keyboard.press('ArrowUp');
   await page.keyboard.press('ArrowUp');

tests/utils/actions/keyboard.ts

@@ -75,10 +75,14 @@ export const withPressKey = async (
   await page.keyboard.up(key);
 };
 
-export async function backsapce(page: Page) {
+export async function pressBackspace(page: Page) {
   await page.keyboard.press('Backspace', { delay: 50 });
 }
 
+export async function pressSpace(page: Page) {
+  await page.keyboard.press('Space', { delay: 50 });
+}
+
 export async function pressEnter(page: Page) {
   // avoid flaky test by simulate real user input
   await page.keyboard.press('Enter', { delay: 50 });