Skip to content

Commit 2ee9bbc

Browse files
comments from the review
1 parent efefbbb commit 2ee9bbc

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/together/cli/api/finetune.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,8 @@ def create(
412412
)
413413
report_string += f" at {formatted_time}"
414414
rprint(report_string)
415+
else:
416+
click.echo("No confirmation received, stopping job launch")
415417
else:
416418
click.echo("No confirmation received, stopping job launch")
417419

src/together/resources/finetune.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -550,6 +550,8 @@ def estimate_price(
550550
raise ValueError(f"Unknown training method: {training_method}")
551551

552552
if training_type.lower() == "lora":
553+
# parameters of lora are unused in price estimation
554+
# but we need to set them to valid values
553555
training_type_cls = LoRATrainingType(
554556
type="Lora",
555557
lora_r=16,

0 commit comments

Comments
 (0)