Add function isObjectReasonablyEqual

Author: tnagorra

lib/src/schema.js

@@ -21,6 +21,18 @@ import {
     hasNoValues,
 } from './utils';
 
+function isObjectReasonablyEqual(foo, bar) {
+    const fooKeys = new Set(Object.getOwnPropertySymbols(foo).map((key, value) => isDefined(value) ? key : undefined).filter(isDefined));
+    const barKeys = new Set(Object.getOwnPropertySymbols(bar).map((key, value) => isDefined(value) ? key : undefined).filter(isDefined));
+    if (fooKeys.count !== barKeys.count) {
+        return false;
+    }
+    if ([...fooKeys].some((fooKey) => !barKeys.has(fooKey))) {
+        return false;
+    }
+    return [...fooKeys].every((fooKey) => foo[fooKey] === bar[fooKey]);
+}
+
 export function accumulateValues(
     obj,
     schema,
@@ -76,7 +88,7 @@ export function accumulateValues(
                 }
                 return schema.defaultValue;
             }
-            // FIXME: should we instead use (return nullable ? null : undefined)?
+            // TODO: should we instead use (return nullable ? null : undefined)?
             return [];
         }
         return values;
@@ -216,7 +228,6 @@ export function accumulateErrors(
     return error;
 }
 
-// FIXME: only copy oldErrors when a change is detected
 export function accumulateDifferentialErrors(
     oldObj,
     newObj,
@@ -246,7 +257,7 @@ export function accumulateDifferentialErrors(
     const isSchemaForObject = !!fields;
 
     if (isSchemaForArray) {
-        const errors = {};
+        let errors = {};
         // FIXME: make this more performant? deps?
         if (validation) {
             const validationErrors = validation(newObj, baseValue, context);
@@ -296,6 +307,9 @@ export function accumulateDifferentialErrors(
             }
         });
 
+        if (isObjectReasonablyEqual(oldError, errors)) {
+            return oldError;
+        }
         return hasNoKeys(errors) ? undefined : errors;
     }
 
@@ -341,6 +355,9 @@ export function accumulateDifferentialErrors(
             }
         });
 
+        if (isObjectReasonablyEqual(oldError, errors)) {
+            return oldError;
+        }
         return hasNoKeys(errors) ? undefined : errors;
     }
 
@@ -397,7 +414,7 @@ export function analyzeErrors(errors) {
 }
 
 // FIXME: move this to a helper
-// FIXME: check conditions for change in context and baseValue
+// TODO: check conditions for change in context and baseValue
 export function addCondition(
     schema,
     value,