the trait `Clone` is not implemented for `http_body::Limited<hyper::Body>` #1818

avdb13 · 2023-03-05T23:27:51Z

avdb13
Mar 5, 2023

According to #1110 the way to use RequestBodyLimitLayer is to return a Router<http_body::Limited<Body>> but this doesn't seem to work in my case. I have several layers on top of my routes so it's pretty tricky to find what part of my code is to blame.

Code:

    pub fn routes(app: Arc<App>, cs: Arc<RwLock<CaptchaService>>) -> Router<http_body::Limited<Body>> {
    let store = MemoryStore::new();
    let secret: Vec<u8> = (0..64).map(|_| rand::random()).collect();
    let session_layer = SessionLayer::new(store, &secret).with_cookie_name("foo");
    let timeout_layer = ServiceBuilder::new()
        .layer(HandleErrorLayer::new(handlers::timeout))
        .timeout(Duration::from_secs(1));
    let parse_fields =
        ServiceBuilder::new().layer(middleware::from_fn_with_state(app.clone(), parse_fields));

    Router::new()
        .merge(SpaRouter::new("/tmp", ".tmp"))
        ...
        .nest("/.api", hidden)
        .layer(RequestBodyLimitLayer::new(10))
        .route_layer(middleware::from_fn(signed_in))
        .layer(session_layer)
        .with_state(app)
        .layer(timeout_layer.into_inner())
        .layer(TraceLayer::new_for_http())
        .layer(DefaultBodyLimit::disable())

Compiler error:

error[E0277]: the trait bound `http_body::Limited<hyper::Body>: Clone` is not satisfied
   --> src/utils/routes.rs:51:5
    |
51  | /     Router::new()
52  | |         .merge(SpaRouter::new("/tmp", ".tmp"))
...   | | ...
60  | |         .layer(session_layer)
61  | |         .with_state(app)
    | |________________________^ the trait `Clone` is not implemented for `http_body::Limited<hyper::Body>`
62  |           .layer(timeout_layer.into_inner())
    |            ----- required by a bound introduced by this call
    |
    = note: required for `http_body::Limited<hyper::Body>` to implement `Clone`
note: required by a bound in `Router::<S, B>::layer`
   --> /home/mikoto/.cargo/registry/src/github.com-1ecc6299db9ec823/axum-0.6.1/src/routing/mod.rs:109:8
    |
109 |     S: Clone + Send + Sync + 'static,
    |        ^^^^^ required by this bound in `Router::<S, B>::layer`
help: consider borrowing here
    |
51  |     &Router::new()
    |     +

error[E0599]: no method named `into_make_service` found for struct `Router<http_body::Limited<hyper::Body>>` in the current scope
  --> src/main.rs:80:23
   |
80 |         .serve(router.into_make_service())
   |                       ^^^^^^^^^^^^^^^^^ method not found in `Router<http_body::Limited<hyper::Body>>`
   |
   = note: the method was found for
           - `Router<(), B>`

Let me know if more details are required to fix my issue.

davidpdrsn · 2023-03-06T07:37:01Z

davidpdrsn
Mar 6, 2023
Collaborator

That issue is slightly out of date. Router has gained the state as it's first type parameter. So you want to return Router<(), http_body::Limited<Body>>.

3 replies

avdb13 Mar 6, 2023
Author

Had this suspicion but it I get a similar error:

error[E0277]: the trait bound `Route: Service<hyper::Request<http_body::Limited<_>>>` is not satisfied
  --> src/utils/routes.rs:67:10
   |
67 |         .layer(RequestBodyLimitLayer::new(10))
   |          ^^^^^ the trait `Service<hyper::Request<http_body::Limited<_>>>` is not implemented for `Route`
   |
   = help: the trait `Service<hyper::Request<B>>` is implemented for `Route<B, E>`
   = note: required for `RequestBodyLimit<Route>` to implement `Service<hyper::Request<_>>`

error[E0277]: the trait bound `Route: Service<hyper::Request<http_body::Limited<_>>>` is not satisfied
   --> src/utils/routes.rs:67:16
    |
67  |         .layer(RequestBodyLimitLayer::new(10))
    |          ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Service<hyper::Request<http_body::Limited<_>>>` is not implemented for `Route`
    |          |
    |          required by a bound introduced by this call
    |
    = help: the trait `Service<hyper::Request<B>>` is implemented for `Route<B, E>`
    = note: required for `RequestBodyLimit<Route>` to implement `Service<hyper::Request<_>>`
note: required by a bound in `Router::<S, B>::layer`
   --> /home/mikoto/.cargo/registry/src/github.com-1ecc6299db9ec823/axum-0.6.1/src/routing/mod.rs:317:21
    |
317 |         L::Service: Service<Request<NewReqBody>> + Clone + Send + 'static,
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Router::<S, B>::layer`

davidpdrsn Mar 14, 2023
Collaborator

I think we need a reproduction script.

avdb13 Apr 18, 2023
Author

Sorry for the late reply (abandoned the project for a bit). This seems to be the culprit:

        .route("/:board/", post(create_post).layer(parse_fields))

parse_fields is of type ServiceBuilder<tower::layer::util::Stack<middleware::FromFnLayer<fn parse_fields(axum::extract::State<Arc<App>>, axum_sessions::extractors::WritableSession, hyper::Request<Body>, middleware::Next<Body>) -> impl Future<Output = Result<impl IntoResponse, askama_axum::Response<http_body::combinators::UnsyncBoxBody<axum::body::Bytes, axum::Error>>>>, Arc<App>, (axum::extract::State<Arc<App>>, axum_sessions::extractors::WritableSession, hyper::Request<Body>)>, tower::layer::util::Identity>> by which I'll assume I transformed my Body into a UnsyncBoxBody.

avdb13 · 2023-04-18T07:17:30Z

avdb13
Apr 18, 2023
Author

pub async fn parse_fields(
    State(app): State<Arc<App>>,
    _session: WritableSession,
    request: Request<hyper::Body>,
    next: Next<hyper::Body>,
) -> Result<impl IntoResponse, Response> {
    let (mut parts, body) = request.into_parts();

    let bytes = hyper::body::to_bytes(body)
        .await
        .map_err(|err| (StatusCode::INTERNAL_SERVER_ERROR, err.to_string()).into_response())?;

    let header = parts.headers.get(CONTENT_TYPE).unwrap();

    let boundary = multer::parse_boundary(header.to_str().unwrap()).unwrap();
    let multipart = multer::Multipart::with_reader(&*bytes, boundary);

    let input = app.models.parse_fields(multipart).await.unwrap();

    let captcha = parts
        .headers
        .get_all(COOKIE)
        .iter()
        .filter_map(|header| header.to_str().ok())
        .flat_map(|header| header.split(';'))
        .filter_map(|header| Cookie::parse_encoded(header.trim()).ok())
        .find(|cookie| cookie.name() == "captcha");

    let expected_hash = hash(input.captcha.as_bytes()).await;
    info!(
        "received captcha: {}, captcha hash: {}",
        &input.captcha,
        base64::encode(expected_hash.clone())
    );

    match captcha {
        Some(captcha) if captcha.value() == base64::encode(expected_hash) => {
            parts.extensions.insert(Ok::<Input, RequestError>(input));
            let request = Request::from_parts(parts, hyper::Body::from(bytes.clone()));

            Ok(next.run(request).await)
        }
        _ => {
            parts
                .extensions
                .insert(Err::<Input, RequestError>(RequestError::IncorrectCaptcha));
            let request = Request::from_parts(parts, hyper::Body::from(bytes.clone()));

            Ok(next.run(request).await)
        }
    }
}

I don't see what's wrong since the last statement, my match pattern returns a Response containing a reconstructed hyper::Body. Any clues?

12 replies

avdb13 Apr 18, 2023
Author

Did the API change or have I been suffering from Mandela effect? I remember trying DefaultBodyLimit before but it didn't work since it took const which meant I couldn't read it from a configuration file.

davidpdrsn Apr 18, 2023
Collaborator

it took const

What do you mean?

Have you tried if it works?

avdb13 Apr 19, 2023
Author

What do you mean?

Have you tried if it works?

Prior to using RequestBodyLimitLayer I remember using DefaultBodyLimit but deciding not to do so anymore since it took a const n which would prevent me from making it dynamically configurable. See the issue that led up to this discussion.

I tried using DefaultBodyLimit like this:

    Router::new()
        .layer(DefaultBodyLimit::disable())
        .merge(SpaRouter::new("/tmp", ".tmp"))
        ...
        .route_layer(middleware::from_fn(signed_in))
        .with_state(app)
        .layer(DefaultBodyLimit::max(1024))
        .layer(session_layer)
        .layer(timeout_layer.into_inner())
        .layer(TraceLayer::new_for_http())

But this doesn't have the effect I was hoping for as I'm still able to upload files well over 10MB, is this because I'm deconstructing the request in my middleware?

davidpdrsn Apr 19, 2023
Collaborator

Prior to using RequestBodyLimitLayer I remember using DefaultBodyLimit but deciding not to do so anymore since it took a const n which would prevent me from making it dynamically configurable

Dunno where you're getting that from. It takes a regular usize just like RequestBodyLimitLayer does.

But this doesn't have the effect I was hoping for as I'm still able to upload files well over 10MB, is this because I'm deconstructing the request in my middleware?

See https://docs.rs/axum/latest/axum/extract/struct.DefaultBodyLimit.html#difference-between-defaultbodylimit-and-requestbodylimit

davidpdrsn Apr 19, 2023
Collaborator

By the way sorry working with all this is so much harder than it should be.

The upside is that for the next major version of axum (0.7) the B type param is removed (#1751). So all these issues should go away and applying RequestBodyLimitLayer doesn't change the router type. 0.7 is planned to come out with hyper 1.0, when that eventually ships.

the trait Clone is not implemented for http_body::Limited<hyper::Body> #1818

Uh oh!

Uh oh!

avdb13 Mar 5, 2023

Replies: 2 comments · 15 replies

Uh oh!

davidpdrsn Mar 6, 2023 Collaborator

Uh oh!

avdb13 Mar 6, 2023 Author

Uh oh!

davidpdrsn Mar 14, 2023 Collaborator

Uh oh!

avdb13 Apr 18, 2023 Author

Uh oh!

avdb13 Apr 18, 2023 Author

Uh oh!

avdb13 Apr 18, 2023 Author

Uh oh!

davidpdrsn Apr 18, 2023 Collaborator

Uh oh!

avdb13 Apr 19, 2023 Author

Uh oh!

davidpdrsn Apr 19, 2023 Collaborator

Uh oh!

davidpdrsn Apr 19, 2023 Collaborator

the trait `Clone` is not implemented for `http_body::Limited<hyper::Body>` #1818

avdb13
Mar 5, 2023

Replies: 2 comments 15 replies

davidpdrsn
Mar 6, 2023
Collaborator

avdb13 Mar 6, 2023
Author

davidpdrsn Mar 14, 2023
Collaborator

avdb13 Apr 18, 2023
Author

avdb13
Apr 18, 2023
Author

avdb13 Apr 18, 2023
Author

davidpdrsn Apr 18, 2023
Collaborator

avdb13 Apr 19, 2023
Author

davidpdrsn Apr 19, 2023
Collaborator

davidpdrsn Apr 19, 2023
Collaborator