Docs Bug, localhost != 0.0.0.0

[mattfbacon]

The hello world example:

use axum::{
    routing::get,
    Router,
};

#[tokio::main]
async fn main() {
    // build our application with a single route
    let app = Router::new().route("/", get(|| async { "Hello, World!" }));

    // run it with hyper on localhost:3000
    axum::Server::bind(&"0.0.0.0:3000".parse().unwrap())
        .serve(app.into_make_service())
        .await
        .unwrap();
}

says "on localhost:3000" but binds to 0.0.0.0 which is not localhost.

[davidpdrsn]

What's the bug? It's still accessible on localhost:3000.

[mattfbacon]

I find it misleading. localhost resolves to 127.0.0.1 but that is not used here.

[mattfbacon]

Anyway, is there a reason you're opposed to changing it?

[davidpdrsn]

Anyway, is there a reason you're opposed to changing it?

No reason. We can change it. Sounds very important to you so feel free to make a PR.

[mattfbacon]

#1984

[traitman]

it's original is not like that.

orig is bind to 127.0.0.1:3000, and I remember someone send a PR change it to 0.0.0.0:3000

[jblachly]

0.0.0.0 is all interfaces, which is a security risk if someone believes this address is localhost

Edit: meant this in reply to @davidpdrsn question