Could you please use type in axum as far as possible?

[lz1998]

https://github.com/tokio-rs/axum/blob/main/axum/src/json.rs#L93

Replace http_body::Body with axum::body::HttpBody. Then if I copy code from axum to implement my own Json or other similar things, I don't need to import http_body in Cargo.toml.

[davidpdrsn]

Sure! PRs are welcome!

[lz1998]

I have created a PR.

#624

[lz1998]

I forgot to run rustfmt. Could you please run the workflows again?

[lz1998]

Sorry, I don't know how to pass this check. It seems strange.

Error:  --> tests/fail/wrong_return_type.rs:4:23
  |
4 | async fn handler() -> bool {
  |                       ^^^^ the trait `IntoResponse` is not implemented for `bool`
  |
note: required by a bound in `__axum_debug_check_handler_into_response::{closure#0}::check`
 --> tests/fail/wrong_return_type.rs:4:23
  |
4 | async fn handler() -> bool {
  |                       ^^^^ required by this bound in `__axum_debug_check_handler_into_response::{closure#0}::check`
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
      your test with the environment variable TRYBUILD=overwrite

[lz1998]

What should I do to pass this check?

error[B004]: found 2 duplicate entries for crate 'itoa'
   ┌─ /github/workspace/Cargo.lock:58:1
   │  
58 │ ╭ itoa 0.4.8 registry+https://github.com/rust-lang/crates.io-index
59 │ │ itoa 1.0.1 registry+https://github.com/rust-lang/crates.io-index
   │ ╰────────────────────────────────────────────────────────────────^ lock entries
   │  
   = itoa v0.4.8
     ├── http v0.2.5
     │   ├── axum v0.4.2
     │   │   └── (dev) axum-core v0.1.1
     │   │       └── axum v0.4.2 (*)
     │   ├── axum-core v0.1.1 (*)
     │   ├── h2 v0.3.9
     │   │   └── hyper v0.14.16
     │   │       ├── axum v0.4.2 (*)
     │   │       ├── (dev) axum-core v0.1.1 (*)
     │   │       ├── hyper-rustls v0.23.0
     │   │       │   └── reqwest v0.11.7
     │   │       │       └── (dev) axum v0.4.2 (*)
     │   │       └── reqwest v0.11.7 (*)
     │   ├── headers v0.3.5
     │   │   └── axum v0.4.2 (*)
     │   ├── headers-core v0.2.0
     │   │   └── headers v0.3.5 (*)
     │   ├── http-body v0.4.4
     │   │   ├── axum v0.4.2 (*)
     │   │   ├── axum-core v0.1.1 (*)
     │   │   ├── hyper v0.14.16 (*)
     │   │   ├── reqwest v0.11.7 (*)
     │   │   └── tower-http v0.2.0
     │   │       ├── (dev) axum v0.4.2 (*)
     │   │       └── axum v0.4.2 (*)
     │   ├── hyper v0.14.16 (*)
     │   ├── hyper-rustls v0.23.0 (*)
     │   ├── multer v2.0.1
     │   │   └── axum v0.4.2 (*)
     │   ├── reqwest v0.11.7 (*)
     │   ├── tower-http v0.2.0 (*)
     │   └── tungstenite v0.16.0
     │       └── tokio-tungstenite v0.16.1
     │           └── axum v0.4.2 (*)
     ├── hyper v0.14.16 (*)
     └── serde_urlencoded v0.7.0
         ├── axum v0.4.2 (*)
         └── reqwest v0.11.7 (*)
   = itoa v1.0.1
     └── serde_json v1.0.73
         ├── (dev) axum v0.4.2
         │   └── (dev) axum-core v0.1.1
         │       └── axum v0.4.2 (*)
         ├── axum v0.4.2 (*)
         ├── reqwest v0.11.7
         │   └── (dev) axum v0.4.2 (*)
         └── reqwest v0.11.7 (*)

warning[L003]: encoding_rs = 0.8.30 is unlicensed
  ┌─ encoding_rs 0.8.30 (registry+https://github.com/rust-lang/crates.io-index):2:9
  │
2 │ name = "encoding_rs"
  │         ^^^^^^^^^^^ a valid license expression could not be retrieved for the crate
3 │ version = "0.8.30"
4 │ license = ""
  │            - license expression was not specified
5 │ license-files = [
6 │     { path = "COPYRIGHT", hash = 0x39f8ad31, score = 0.14 },
  │                                                      ---- low confidence in the license text
  │
  = encoding_rs v0.8.30
    ├── multer v2.0.1
    │   └── axum v0.4.2
    │       └── (dev) axum-core v0.1.1
    │           └── axum v0.4.2 (*)
    └── reqwest v0.11.7
        └── (dev) axum v0.4.2 (*)

warning[L002]: license requirements satisfied
  ┌─ webpki-roots 0.21.1 (registry+https://github.com/rust-lang/crates.io-index):4:12
  │
4 │ license = "MPL-2.0"
  │            ^^^^^^^
  │            │
  │            license expression retrieved via Cargo.toml `license`
  │            accepted: license is considered copyleft
  │
  = webpki-roots v0.21.1
    └── reqwest v0.11.7
        └── (dev) axum v0.4.2
            └── (dev) axum-core v0.1.1
                └── axum v0.4.2 (*)

bans FAILED, licenses ok, sources ok

[davidpdrsn]

Please post in the PR.