axum-extra: Make typed-routing feature enable routing feature #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
check-axum-extra-typed-routing
branch
from
f9f1dc8 to
63513eb
Compare
|
I see, this is due to #3485. But I don't think this is the right solution. Shouldn't we just make the |
tottoto
force-pushed
the
check-axum-extra-typed-routing
branch
from
63513eb to
bb2b5bc
Compare
tottoto
changed the title
|
Yes, that is also possible. The original change was intended to fix the current check. Updated. |
jplatte
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since
axum-extra'styped-routingfeature requiresroutingfeature, both are needed to be enabled to be checked.Solution
Adds an check of
axum-extrawith enabling both ofroutingandtyped-routingfeatures.